Repository navigation
Add Page object - #23
Merged
Merged
Conversation
- add showAbout method
Contributor
Author
camillobruni
commented
Oct 13, 2022
camillobruni
commented
Oct 13, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
rniwa
reviewed
Nov 11, 2022
squarewave
reviewed
Nov 15, 2022
squarewave
left a comment
squarewave
left a comment
Contributor
There was a problem hiding this comment.
This all looks good to me, as far as the substance of the change goes. Thanks for taking this on.
Contributor
Author
|
I've addressed your comments. |
rniwa
reviewed
Nov 17, 2022
rniwa
reviewed
Nov 17, 2022
rniwa
reviewed
Nov 17, 2022
bgrins
self-requested a review
November 18, 2022 15:52
bgrins
approved these changes
Nov 18, 2022
bgrins
left a comment
bgrins
left a comment
Contributor
There was a problem hiding this comment.
Approving as per Doug's comment
Contributor
|
@camillobruni is this good to land? |
Contributor
Author
|
Sorry, long weekend. double checking now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: Add a fixed interface to interact with test frames and their DOM nodes.
This will allow us to run more complex scenarios in the future without sacrificing flexibility or performance for the existing tests.
Pageobject