Skip to content

Remove flight-js mailclient - #22

Merged
camillobruni merged 17 commits into
WebKit:mainfrom
camillobruni:2022-10-13_remove_mailclient
Oct 31, 2022
Merged

Remove flight-js mailclient#22
camillobruni merged 17 commits into
WebKit:mainfrom
camillobruni:2022-10-13_remove_mailclient

Conversation

@camillobruni

@camillobruni camillobruni commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

Remove the flightjs-mailclient app that was not included in the main Suites list.

@camillobruni

camillobruni commented Oct 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Depends on #19

Up for discussion:
I thought we can remove this benchmark as it was not part of the original suite.
For the future Page migration, I see some additional work coming up to make the benchmark work better. However, we could move the inner step-iterations implementation to the app itself to be able to rely on the full DOM API without being restricted on the Page object.

@camillobruni camillobruni changed the title WIP: Remove flight-js mailclient Remove flight-js mailclient Oct 13, 2022
camillobruni
camillobruni commented Oct 13, 2022
View reviewed changes
Comment thread index.html Resolved
@camillobruni camillobruni mentioned this pull request Oct 13, 2022
Merged
@camillobruni
camillobruni requested a review from rniwa October 31, 2022 09:33
rniwa
rniwa approved these changes Oct 31, 2022
View reviewed changes

@rniwa rniwa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@camillobruni
camillobruni merged commit b840b30 into WebKit:main Oct 31, 2022
squarewave pushed a commit to squarewave/Speedometer that referenced this pull request Nov 7, 2022
@camillobruni @squarewave
Remove flight-js mailclient (WebKit#22)
72fc971 
Remove the flightjs-mailclient app that was not included in the main Suites list.
@camillobruni
camillobruni deleted the 2022-10-13_remove_mailclient branch November 30, 2022 18:29
bgrins pushed a commit to mozilla/Speedometer that referenced this pull request Jun 30, 2023
@issackjohn
Issackjohn/some clean up of complex dom versions (WebKit#22)
a38d196 
* del tenative/complex-static-html from .gitignore
* tentative/complex-static-html removed.
* restore missing png
* update big-dom-generator readme and build scripts
* generated css now doesn't upset formatter
* building everything again just in case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rniwa rniwa rniwa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camillobruni @rniwa