Repository navigation
Add more Page methods and PageElement - #26
Merged
Merged
Conversation
- add showAbout method
Contributor
Author
|
This PR depends no #23 |
camillobruni
changed the title
camillobruni
force-pushed
the
2022-11-07_PageNode
branch
from
November 23, 2022 21:54
2346fab to
9957e09
Compare
Contributor
Author
|
This should be clean for review now. |
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
rniwa
reviewed
Nov 28, 2022
Contributor
Author
|
Update the PR and added all missing semicolons (hopefully :P) |
squarewave
approved these changes
Nov 30, 2022
squarewave
left a comment
squarewave
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I would be fine with this landing as-is, but I do have a nit and a question below.
bgrins
approved these changes
Nov 30, 2022
bgrins
left a comment
bgrins
left a comment
Contributor
There was a problem hiding this comment.
Unblocking landing based on @squarewave's review - this shouldn't be required for future reviews once he's added to the repo officially
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate all test code to go through Page or PageElement.
Cleanups:
even.initEvent(...)code to use the recommendedEventconstructorDepending on #29