Repository navigation
fix(release): cap proxied plain-http responses, count Firecrawl depth from the start URL, and drop stale route cache on upgrade - #9860
Merged
Conversation
… from the start URL, and drop stale route cache on upgrade
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issues remain. SummaryThe PR caps plain-HTTP responses sent through a proxy, counts Firecrawl depth from the starting URL, and clears route pages saved by another build.
Reviews (2) · Last reviewed commit: "fix(firecrawl): read a scheme-less start..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
6 tasks done
waleedlatif1
added a commit
that referenced
this pull request
Nov 10, 2026
Drops the response cap and crawl depth (landed in #9860), CONTRIBUTING (#9860), Firecrawl search sources (on hold), Databricks JSON caps (#9859), and the workflow middleware and route-policies cleanups (#9858). Drops the NO_PROXY entry-syntax docs line (owned by a separate NO_PROXY change). Generated files regenerated on current staging.
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxResponseSizefor every dispatcher, not only decoded bodies. undici'sProxyAgentforwards plain-http requests through a client that drops the option, so withHTTP_PROXYset anhttp://destination could stream an unbounded body (MCP OAuth fetches, configured endpoints).maxDepthfrom the starting URL, as v1 did (index files add no depth). Counting from the domain root made the start URL fail its own path filter, so a crawl starting on a deep page returned 0 pages.npx sim-setupinstead of the retiredsimstudioCLI.Type of Change
Testing
bootstrap.tswith the Dockerfile'sbun buildcommand and ran it against a fake standalone dir: old page cleared, build marker written, server started.check:comment-hygiene,check:file-names,check:boundaries,check:utils; regenerated tool metadata and integration docs.Checklist
test-auditauthoring gate)