Skip to content

improvement(api): release audit follow-ups for v2 member analytics, workflow access middleware and docs - #9858

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/release-audit-2026-11-10
Nov 11, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/release-audit-2026-11-10

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • v2 workspace member role change and removal now emit the same workspace_member_role_changed / workspace_member_removed analytics events as the in-app routes (user-credential principals only, matching the other v2 routes)
  • Removed the unreachable requireDeployment=true branch from validateWorkflowAccess; every caller already passed false, and the dead branch authenticated API keys without the read-only check
  • Moved the workspace-concealment doc comment back onto v2WorkspaceErrorPolicies and inlined the busy-error predicate
  • GitLab permissions CI recipe now says the key needs Full access (a read-only key can read the revision but the CSV replace returns 403)

Type of Change

  • Improvement

Testing

  • app/api/workflows, app/api/resume, app/api/v2/workspaces, lib/workspaces/api suites (172 tests) and bun run lint; type-check and audits run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 10, 2026 11:52pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/CONTRIBUTING.md Resolved
@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds member analytics to the v2 workspace routes and removes an unused workflow access branch.

  • V2 workspace member changes now send analytics events.
  • Workflow reads now use one shared access check.
  • The GitLab CI guide names the key access needed to replace permission files.
  • Busy workspace requests keep their retry response.

No actionable issues found. Review used code inspection; tests were not run.

Reviews (3) · Last reviewed commit: "improvement(api): release audit follow-u..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the fix/release-audit-2026-11-10 branch from 9b60201 to de7e736 Compare November 10, 2026 23:46
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

waleedlatif1 added a commit that referenced this pull request Nov 10, 2026
Drops the response cap and crawl depth (landed in #9860), CONTRIBUTING (#9860), Firecrawl search sources (on hold), Databricks JSON caps (#9859), and the workflow middleware and route-policies cleanups (#9858). Drops the NO_PROXY entry-syntax docs line (owned by a separate NO_PROXY change). Generated files regenerated on current staging.
@waleedlatif1
waleedlatif1 merged commit e1a8ea0 into staging Nov 11, 2026
83 of 84 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/release-audit-2026-11-10 branch November 11, 2026 00:28

This branch was successfully deployed

1 active deployment
Preview — de7e736d Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant