Skip to content

fix(ci): pin node-pre-gyp to 1.0.8 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weeyum merged 4 commits into from
Nov 13, 2026
+2 −2
Merged

fix(ci): pin node-pre-gyp to 1.0.8 #21

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d2f4d8
fix(ci): use the local release packager
ernest-figma Nov 13, 2026
78601bc
fix(ci): pin the global release packager
ernest-figma Nov 13, 2026
40c63ac
test(ci): package native modules in pull requests
ernest-figma Nov 13, 2026
2b588be
fix(ci): keep only the release packager pin
ernest-figma Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
- name: Deploy
if: startsWith(github.ref, 'refs/tags/v')
run: |
npm install -g @mapbox/node-pre-gyp aws-sdk
npm install -g @mapbox/node-pre-gyp@1.0.8 aws-sdk
node lifecycleScripts/clean
node-pre-gyp package

@cursor cursor Bot Nov 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR jobs skip packaging verification

High Severity

The unconditional Package step was folded into tag-only Deploy, so node-pre-gyp package no longer runs on pull requests. Packaging failures will only appear when a v* tag is pushed, after merge, which is the gap this change set out to close.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2b588be. Configure here.

node-pre-gyp publish
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:
- name: Deploy
if: startsWith(github.ref, 'refs/tags/v')
run: |
npm install -g @mapbox/node-pre-gyp aws-sdk
npm install -g @mapbox/node-pre-gyp@1.0.8 aws-sdk
node lifecycleScripts/clean
node-pre-gyp package
node-pre-gyp publish
Loading