Repository navigation
fix(ci): pin node-pre-gyp to 1.0.8 - #21
Conversation
| run: | | ||
| npm install -g @mapbox/node-pre-gyp@1.0.8 aws-sdk | ||
| node lifecycleScripts/clean | ||
| node-pre-gyp package |
There was a problem hiding this comment.
Dropped duplicate module cleanup
High Severity
The new Package steps never remove build/Release/obj.target/nodegit.node before node-pre-gyp package. That cleanup lived in Deploy and was not carried over, so Linux still archives the duplicate native module that this change is meant to strip.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 40c63ac. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Reviewed by Cursor Bugbot for commit 2b588be. Configure here.
| npm install -g @mapbox/node-pre-gyp aws-sdk | ||
| npm install -g @mapbox/node-pre-gyp@1.0.8 aws-sdk | ||
| node lifecycleScripts/clean | ||
| node-pre-gyp package |
There was a problem hiding this comment.
PR jobs skip packaging verification
High Severity
The unconditional Package step was folded into tag-only Deploy, so node-pre-gyp package no longer runs on pull requests. Packaging failures will only appear when a v* tag is pushed, after merge, which is the gap this change set out to close.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 2b588be. Configure here.


Why
Fix the Linux release packaging error by pinning the global packager to the version in the existing lockfile.
What changed
Pin
@mapbox/node-pre-gypto1.0.8in both global install commands. Keepaws-sdkin those commands.Scope
Two version pins in one workflow file. All other workflow lines match the base.
Blast Radius
Only tag release jobs use these global install commands. Existing tag reruns retain their original workflow revision.
Verification
git diff --checkpassed. CI for this final revision is pending.