Skip to content

fix(ci): pin node-pre-gyp to 1.0.8 - #21

Merged
weeyum merged 4 commits into
figma:figmafrom
ernest-figma:ernest/fix-release-packager
Nov 13, 2026
Merged

weeyum merged 4 commits into
figma:figmafrom
ernest-figma:ernest/fix-release-packager

Conversation

@ernest-figma

@ernest-figma ernest-figma commented Nov 13, 2026 •

Copy link
Copy Markdown

Why

Fix the Linux release packaging error by pinning the global packager to the version in the existing lockfile.

What changed

Pin @mapbox/node-pre-gyp to 1.0.8 in both global install commands. Keep aws-sdk in those commands.

Scope

Two version pins in one workflow file. All other workflow lines match the base.

Blast Radius

Only tag release jobs use these global install commands. Existing tag reruns retain their original workflow revision.

Verification

  • The temporary CI run passed all six Linux test and package jobs with version 1.0.8 and both native module paths retained. These results apply to the preceding revision, before the added CI steps were reverted.
  • The final workflow was compared byte for byte with the base. Only the two version pins differ, and git diff --check passed. CI for this final revision is pending.
  • Archive extraction and S3 publication were not checked by the temporary PR CI run.

@ernest-figma ernest-figma changed the title fix(ci): use the local release packager fix(ci): pin node-pre-gyp for release archives Nov 13, 2026
@ernest-figma ernest-figma changed the title fix(ci): pin node-pre-gyp for release archives fix(ci): pin node-pre-gyp and test packaging Nov 13, 2026

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread .github/workflows/tests.yml Outdated
run: |
npm install -g @mapbox/node-pre-gyp@1.0.8 aws-sdk
node lifecycleScripts/clean
node-pre-gyp package

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped duplicate module cleanup

High Severity

The new Package steps never remove build/Release/obj.target/nodegit.node before node-pre-gyp package. That cleanup lived in Deploy and was not carried over, so Linux still archives the duplicate native module that this change is meant to strip.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 40c63ac. Configure here.

@ernest-figma ernest-figma changed the title fix(ci): pin node-pre-gyp and test packaging fix(ci): pin node-pre-gyp to 1.0.8 Nov 13, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 2b588be. Configure here.

npm install -g @mapbox/node-pre-gyp aws-sdk
npm install -g @mapbox/node-pre-gyp@1.0.8 aws-sdk
node lifecycleScripts/clean
node-pre-gyp package

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR jobs skip packaging verification

High Severity

The unconditional Package step was folded into tag-only Deploy, so node-pre-gyp package no longer runs on pull requests. Packaging failures will only appear when a v* tag is pushed, after merge, which is the gap this change set out to close.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2b588be. Configure here.

@weeyum
weeyum merged commit abaa6e0 into figma:figma Nov 13, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants