Repository navigation
chore(main): release 10.9.0 - #773
Conversation
[Low impact] The release appears safe to merge, with non-blocking corrections needed in the release notes. FindingsFix with agent prompt### Issue 1
CHANGELOG.md:18-21
These notes say `Directories.find` loses `id` and changes its return type. The Python API still exposes `get_directory(id) -> Directory`; the group lookup is a separate `get_directory_group(directory_id, group_id)` method. This tells users to prepare for a breaking change that does not affect their existing directory lookup.
Replace these claims, including the return-type claim below, with the actual Python additions and deprecations.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
### Issue 2
CHANGELOG.md:10-12
The new entry describes an agent hand-rolling HMAC verification and ends mid-sentence. The referenced commit only adds README guidance for existing webhook methods; it does not change verification behavior. Users checking whether to upgrade cannot tell what this release changes.
Replace the text with “Document webhook signature verification with Django” and place it under Documentation.
```suggestion
### Documentation
* Document webhook signature verification with Django ([#736](https://github.com/workos/workos-python/issues/736)) ([6e6d782](https://github.com/workos/workos-python/commit/6e6d782b0efb41fd21033b121ca6480c23da1f68))
```
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryPrepares the
Reviews (6) · Last reviewed commit: "chore: inline release notes from .change..." · Reviewed by Greptile |
| ### Bug Fixes | ||
|
|
||
| * **sdk:** webhooks-django × codex-baseline — The agent hand-rolled HMAC signature verification (parsing a… ([#736](https://github.com/workos/workos-python/issues/736)) ([6e6d782](https://github.com/workos/workos-python/commit/6e6d782b0efb41fd21033b121ca6480c23da1f68)) |
There was a problem hiding this comment.
The new entry describes an agent hand-rolling HMAC verification and ends mid-sentence. The referenced commit only adds README guidance for existing webhook methods; it does not change verification behavior. Users checking whether to upgrade cannot tell what this release changes.
Replace the text with “Document webhook signature verification with Django” and place it under Documentation.
| ### Bug Fixes | |
| * **sdk:** webhooks-django × codex-baseline — The agent hand-rolled HMAC signature verification (parsing a… ([#736](https://github.com/workos/workos-python/issues/736)) ([6e6d782](https://github.com/workos/workos-python/commit/6e6d782b0efb41fd21033b121ca6480c23da1f68)) | |
| ### Documentation | |
| * Document webhook signature verification with Django ([#736](https://github.com/workos/workos-python/issues/736)) ([6e6d782](https://github.com/workos/workos-python/commit/6e6d782b0efb41fd21033b121ca6480c23da1f68)) |
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 6-8
Comment:
**Release note hides the change**
The new entry describes an agent hand-rolling HMAC verification and ends mid-sentence. The referenced commit only adds README guidance for existing webhook methods; it does not change verification behavior. Users checking whether to upgrade cannot tell what this release changes.
Replace the text with “Document webhook signature verification with Django” and place it under Documentation.
```suggestion
### Documentation
* Document webhook signature verification with Django ([#736](https://github.com/workos/workos-python/issues/736)) ([6e6d782](https://github.com/workos/workos-python/commit/6e6d782b0efb41fd21033b121ca6480c23da1f68))
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
4b9f211 to
10983d3
Compare
187d68c to
ed9ad6c
Compare
3281085 to
ebf6b21
Compare
| * Added parameter `Directories.find.directoryId` | ||
| * Added parameter `Directories.find.groupId` | ||
| * Removed parameter `Directories.find.id` | ||
| * Changed path for endpoint `GET /directories/{directoryId}/groups/{groupId}` |
There was a problem hiding this comment.
Directory upgrade notes are wrong
These notes say Directories.find loses id and changes its return type. The Python API still exposes get_directory(id) -> Directory; the group lookup is a separate get_directory_group(directory_id, group_id) method. This tells users to prepare for a breaking change that does not affect their existing directory lookup.
Replace these claims, including the return-type claim below, with the actual Python additions and deprecations.
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 18-21
Comment:
**Directory upgrade notes are wrong**
These notes say `Directories.find` loses `id` and changes its return type. The Python API still exposes `get_directory(id) -> Directory`; the group lookup is a separate `get_directory_group(directory_id, group_id)` method. This tells users to prepare for a breaking change that does not affect their existing directory lookup.
Replace these claims, including the return-type claim below, with the actual Python additions and deprecations.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
🤖 Created releases: 🌻 |
🤖 I have created a release beep boop
10.9.0 (2026-11-13)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.