Repository navigation
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
| console.error('Generating %j for the API endpoint %j', ngModuleName, apiUrl); | ||
| var result = generator.services(app, ngModuleName, apiUrl); | ||
| console.error('Generating %j for the API endpoint %j', ngModuleName, apiUrl, includeSchemas); | ||
| var result = generator.services(app, ngModuleName, apiUrl, includeSchemas); |
Member
There was a problem hiding this comment.
@akera-io Could you please rework this line to use the new options-based API introduced in strongloop/loopback-sdk-angular#223?
Member
|
@akera-io sorry for the delay. Could you please address my comment above and add a unit-test to verify the new option? |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Member
|
@slnode ok to test |
Member
|
I am closing this pull request as abandoned. @akera-io feel free to reopen whenever you have time to address my comments above:
and also rebase the patch on top of the current master. |
Member
|
Landed via #55. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That goes together with the other pull request strongloop/loopback-sdk-angular#194 done on loopback-sdk-angular about adding the option to include model definition (properties) into the generated resources, the client need to be able to use the option.