Repository navigation
ci: match seed proposals by head repository - #235
Merged
Merged
Conversation
The propose job looked up the open pull request with gh pr list --head, which filters on the branch name alone, so a fork branch named after the automation branch would have received the bot's title and body while the real proposal was never opened. Resolve the proposal through the pulls API with the owner-qualified head and the same head-repository filter the unprivileged pre-check applies, and fail closed on more than one match. Signed-off-by: Patrick Linnane <patrick@linnane.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seed propose jobs looked up the open proposal with
gh pr list --head, which matches the branch name alone, so a fork pull request named after the automation branch would have received the bot's title and body while the real proposal was never opened. Both workflows now resolve the proposal through the pulls API with the owner-qualified head and the same head-repository filterscripts/seed-proposal-needed.rbapplies, fail closed when the count cannot be read or more than one proposal matches, and the workflow spec pins the lookup shape.AI disclosure: Claude Mythos 5.1 with just check on this commit and scripted reproductions of the proposal lookup against a failing jq and zero, one and two open proposals.