postgres partition by hash failure #352

Activity

1. kyleconroy

   added

   📚 postgresql

   upstreamIssue is caused by a dependencyIssue is caused by a dependency

   on Feb 24, 2020
2. kyleconroy commented on Feb 24, 2020

   

   kyleconroy

   on Feb 24, 2020

   Collaborator

   More actions

   sqlc relies on https://github.com/lfittl/pg_query_go, which currently uses the PostgreSQL 10 parser. The PARTITION BY HASH syntax was introduced in PostgreSQL 11. I've opened up an issue to get pg_query_go updated for PostgreSQL 11: https://github.com/lfittl/pg_query_go/issues/26
3. yarelm commented on Mar 1, 2020

   

   yarelm

   on Mar 1, 2020

   Author

   More actions

   Thanks.
   Any workaround to get around this at this time?

   the partitioned table actually shouldn't relate to sqlc code generation, any way to make sqlc ignore this line?
4. kyleconroy commented on Mar 1, 2020

   

   kyleconroy

   on Mar 1, 2020

   Collaborator

   More actions

   I was going to say that there isn't a workaround, but you can actually use the migration support to have sqlc ignore the CREATE TABLE "user_1" statement.

   CREATE TABLE "user" (
       "id" uuid PRIMARY KEY,
       "other_id" uuid NOT NULL,
     ...
   ) PARTITION BY HASH (other_id);
   
   -- +migrate Down
   CREATE TABLE "user_1" PARTITION OF "user" FOR VALUES WITH (MODULUS 10, REMAINDER 0); 

   I know this isn't an ideal solution, but it's the only current way to make it work. I may consider adding support for an -- ignore comment.

   👍React with 👍1Reacted by Yarel
5. kyleconroy

   added this to the v1.8.0 milestone on Mar 19, 2021
6. kyleconroy

   closed this as completedin #951on Mar 20, 2021