Skip to content

fix(mistral): say V3 parses an uploaded or referenced PDF, and bound Max Images at 100 - #9872

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/mistral-parser-v3-copy-and-image-cap
Nov 11, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/mistral-parser-v3-copy-and-image-cap

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Two review findings on the Mistral Parser image extraction (#9856), raised on the v0.9.53 release PR.

  • The V3 block's long description said it parses PDFs "from a URL", but V3 takes only an uploaded file or a file reference from a previous block (a URL string fails normalizeFileInput with "PDF document is required"). It now says "an uploaded PDF or a file from a previous block". V1 and V2 do accept URLs and are unchanged
  • Max Images now rejects values above 100 at the field instead of the server silently clamping them; 0 still means the default of 100. The cap moved to one client-safe constant, MAX_OCR_EXTRACTED_IMAGES in tools/mistral/types.ts (type-only imports), shared by the block's bound, the server's image_limit clamp, and the extraction loop. The placeholder and tool description keep the literal 100 because the docs generator strips ${...} from source strings

No effect on v1/v2 (they never request images), the knowledge-base OCR path (doesn't use imageLimit), or agent-tool calls (imageLimit is user-only).

Type of Change

  • Bug fix

Testing

  • bunx vitest run lib/internal/mistral tools/mistral blocks — 852 passed
  • check-block-registry.ts origin/staging, check:docs, check:integration-catalog, check:canvas-sentences, check:client-boundary, check:tool-registry-boundary --check, check:comment-hygiene; regenerated docs and integrations catalog
  • lint:check + type-check via the pre-push hook; full gate left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 11, 2026 2:24am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the previous docs issue is fixed and no new issues were found.

Summary

Corrects V3 input guidance and shares the 100-image cap across the block and server.

  • Mistral Parser V3 names the file inputs it accepts.
  • Max Images rejects values above 100 before a run starts.

Reviews (2) · Last reviewed commit: "docs(mistral): the V3 intro takes an upl..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was successfully deployed

1 active deployment
Preview — a2449617 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant