Skip to content

fix(release): small release-audit cleanups - #9863

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/release-audit-small-cleanups
Nov 11, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/release-audit-small-cleanups

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Pause points read once: a paused run's status read reused the pause points it had already loaded instead of querying paused_executions a second time. The returned data is unchanged.
  • Auto-disable log fires once: a polling webhook logs "auto-disabled" only when this failure actually disables it, not on every later failure of a row that was already off. It still runs as one race-free statement, which now also returns the prior state.
  • Accurate scopes in /api/v2/meta: it reports the scopes a credential can actually reach, using the same check enforcement uses:
    • Write tokens and full-access keys report api:read, api:write and search:read.
    • Read-only keys report api:read and search:read.
    • Enforcement is unchanged.
  • Docs: MACHINE_ACCESS.md names MCP TypeScript SDK 2.4.0.

Type of Change

  • Bug fix

Testing

  • Unit tests: read-workflow-run, runs, webhooks/polling/utils, oauth-authorization, read-v2-api-capabilities, v2-api-key-auth.
  • Integration tests (real Postgres/Redis): triggers.integration.ts covers the auto-disable log firing once. read-only-access.integration.ts covers meta scopes. read-workflow-run-pause.integration.ts and pause-persistence.integration.ts cover pause points. 38/38 pass.
  • New guards: the auto-disable log and meta scopes each have a test that fails when the fix is reverted.
  • Commands: bun run lint, bun run --cwd apps/sim type-check, check-block-registry.ts origin/staging, check:test-patterns, check:cli-api, check:cli-docs, check:api-validation:strict, check:openapi, check:docs, check:tool-metadata, check:docs-manifest, check:comment-hygiene, check:source-conventions.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 11, 2026 12:13am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 16 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The PR reuses loaded pause points, logs webhook auto-disable only when it happens, reports implied credential scopes, and updates the documented MCP SDK version.

  • Paused run details reuse pause points already loaded for status.
  • Polling failures log only when they turn a webhook off.
  • API metadata lists every scope a credential can reach.
  • Machine access docs name MCP TypeScript SDK 2.4.0.

Reviews (3) · Last reviewed commit: "test(mcp): expect the search:read scope ..." · Reviewed by Greptile

- Read a paused run's pause points once per status read instead of
  querying paused_executions twice.
- Log a polling webhook's auto-disable only when this failure disables
  it, in the same race-free statement.
- /api/v2/meta reports the scopes a credential can actually reach,
  using the same check enforcement uses. Enforcement is unchanged.
- MACHINE_ACCESS.md names MCP TypeScript SDK 2.4.0.
@waleedlatif1
waleedlatif1 force-pushed the fix/release-audit-small-cleanups branch from ce91c46 to 1561c09 Compare November 10, 2026 23:49
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — 2d81a825 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant