Repository navigation
Provide config option to disable showing line numbers #881
Description
Your proposal
Provide a config option to disable showing line numbers.
Example:
config set show_line_numbers trueshows line numbers (the default)config set show_line_numbers falsehides line numbers (likepry's@ -n)
Additional context
This is particularly useful when copying code from the debug session.
Activity
gwillcox-r7 commentedon Jan 5, 2023
Initial inspection using Sourcegraph shows this will likely require updating
check_line_num!intest/support/test_case.rbas noted at https://sourcegraph.com/github.com/ruby/debug/-/blob/test/support/test_case.rb?L66-71, accounting fortest_the_test_fails_when_the_script_doesnt_have_line_numbersat https://sourcegraph.com/github.com/ruby/debug/-/blob/test/support/test_case_test.rb?L22-28, and updating https://sourcegraph.com/github.com/ruby/debug/-/blob/test/support/assertions.rb?L5-9 intest/support/assertions.rb.This would be in addition to adding in the new option. Looks like line numbers are currently tied into the current test stack quite a bit. It might be possible to remove this dependency but the changes would need to be careful to properly handle the cases above, and we would also potentially need to make sure callers of those functions update their function calls if we change the parameters of any of these calls.
ko1 commentedon Mar 7, 2023
Do you want to remove "current line" marker too?
ko1 commentedon Mar 7, 2023
Could you write the current output and expected output with small code?
(it is easy to understand the request)
`no_lineno` config optiopn (default: false)
`no_lineno` config optiopn (default: false)
`no_lineno` config optiopn (default: false)
ko1 commentedon May 5, 2023
#973