Repository navigation
Add 3.12 examples from the typing preview - #438
Merged
Merged
Conversation
Contributor
Author
|
I see that the linters are crashing on the new type variable syntax. I'll investigate whether we can update linters, or if we should do what Leodanis did for the f-strings, and provide the new syntax within comments. |
bzaczynski
requested changes
Sep 20, 2023
|
|
||
| ### Static Typing Improvements | ||
|
|
||
| You'll find all static typing examples inside the [`typing/`](typing/) directory. You should install the Pyright type checker for PyPI: |
Contributor
There was a problem hiding this comment.
✍️ Typo
Should this be from instead of for? 🤔
Suggested change
| You'll find all static typing examples inside the [`typing/`](typing/) directory. You should install the Pyright type checker for PyPI: | |
| You'll find all static typing examples inside the [`typing/`](typing/) directory. You should install the Pyright type checker from PyPI: |
Comment on lines
+155
to
+160
| - [`generic_queue.py`](typing/generic_queue.py) and [`generic_queue_311.py`](typing/generic_queue_311.py) | ||
| - [`list_helpers.py`](typing/list_helpers.py) and [`list_helpers_311.py`](typing/list_helpers_311.py) | ||
| - [`concatenation.py`](typing/concatenation.py) and [`concatenation_311.py`](typing/concatenation_311.py) | ||
| - [`inspect_string.py`](typing/inspect_string.py) and [`inspect_string_311.py`](typing/inspect_string_311.py) | ||
| - [`deck.py`](typing/deck.py) and [`deck_311.py`](typing/deck_311.py) | ||
| - [`alias.py`](typing/alias.py) and [`alias_311.py`](typing/alias_311.py) |
Contributor
There was a problem hiding this comment.
Missing files? I'm not seeing the *_311.py files in this pull request.
Contributor
Author
There was a problem hiding this comment.
Ah, sorry. I had updated the README to remove these links after I combined the 3.11 and 3.12, but the README wasn't committed. Should be fixed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where to put new files:
my-awesome-articleHow to merge your changes: