Repository navigation
Conversation
…project We need this since React 15.0.0 is coming and will break `react-native init`, which currently installs the latest version of React. We'll need some changes to React Native to support 15 that Sebastian is actively working on, but till that lands we want `react-native init` to continue working. Test Plan: Run `scripts/test-manual-e2e.sh` and verify that it ran `npm install react@^0.14.5 --save` instead of `npm install react --save`.
ide
changed the title
Contributor
Author
|
Will cherry-pick this into 0.24 and we might want this in 0.23 too so that the release React 15 doesn't break things... cc @mkonicek |
Contributor
facebook-github-bot
added
GH Review: review-needed
CLA Signed
4 tasks done
Contributor
|
I think this looks good and since it only affects open source builds it shouldn't break any of our stuff. So I'll just land it for now. @facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Contributor
Author
|
@facebook-github-bot shipit |
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
1 similar comment
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
ide
added a commit
that referenced
this pull request
Apr 7, 2016
…ject Summary:We need this since React 15.0.0 is coming and will break `react-native init`, which currently installs the latest version of React. We'll need some changes to React Native to support 15 that Sebastian is actively working on, but till that lands we want `react-native init` to continue working. Closes #6846 Differential Revision: D3148182 Pulled By: sebmarkbage fb-gh-sync-id: 3df5bc184c0b82d2c9c320c620256c7c8568d90b fbshipit-source-id: 3df5bc184c0b82d2c9c320c620256c7c8568d90b
Contributor
|
What's the status on shipping this? |
Contributor
Author
|
We've shipped this fix in 0.24.0-rc3 and still need to ship it in 0.23.1. Do you want to discuss the release schedule on IRC? |
ide
added a commit
that referenced
this pull request
Apr 7, 2016
…ject Summary:We need this since React 15.0.0 is coming and will break `react-native init`, which currently installs the latest version of React. We'll need some changes to React Native to support 15 that Sebastian is actively working on, but till that lands we want `react-native init` to continue working. Closes #6846 Differential Revision: D3148182 Pulled By: sebmarkbage fb-gh-sync-id: 3df5bc184c0b82d2c9c320c620256c7c8568d90b fbshipit-source-id: 3df5bc184c0b82d2c9c320c620256c7c8568d90b
Contributor
Author
|
RN 0.23.1 is ready for 15.0: https://github.com/facebook/react-native/releases/tag/v0.23.1 |
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
…ject Summary:We need this since React 15.0.0 is coming and will break `react-native init`, which currently installs the latest version of React. We'll need some changes to React Native to support 15 that Sebastian is actively working on, but till that lands we want `react-native init` to continue working. Closes react#6846 Differential Revision: D3148182 Pulled By: sebmarkbage fb-gh-sync-id: 3df5bc184c0b82d2c9c320c620256c7c8568d90b fbshipit-source-id: 3df5bc184c0b82d2c9c320c620256c7c8568d90b
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
…ject Summary:We need this since React 15.0.0 is coming and will break `react-native init`, which currently installs the latest version of React. We'll need some changes to React Native to support 15 that Sebastian is actively working on, but till that lands we want `react-native init` to continue working. Closes react/react-native#6846 Differential Revision: D3148182 Pulled By: sebmarkbage fb-gh-sync-id: 3df5bc184c0b82d2c9c320c620256c7c8568d90b fbshipit-source-id: 3df5bc184c0b82d2c9c320c620256c7c8568d90b
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need this since React 15.0.0 is coming and will break
react-native init, which currently installs the latest version of React. We'll need some changes to React Native to support 15 that Sebastian is actively working on, but till that lands we wantreact-native initto continue working.Test Plan: Run
scripts/test-manual-e2e.shand verify that it rannpm install react@^0.14.5 --saveinstead ofnpm install react --save.