Repository navigation
Conversation
Summary: Build the Fantom native tester and Hermes compiler with the standard Linux and macOS build modes instead of the previous per-platform mode set, matching how other internal test runners build their native binaries. - Linux uses the `dev-nosan`, `opt`, `dev-asan`, `dev-tsan`, `dev-cov` and `opt-cov` modes, linked statically because the runner copies the binaries out of the build output directory. - macOS uses the macOS platform mode plus separate production, sanitizer and coverage modes. Each mode file is now passed as its own argument; joining them into one space-separated argument made Buck fail to resolve the flag file. The macOS modes do not set the dev/opt build mode constraint, so the runner sets it explicitly; otherwise optimized macOS builds were compiled with `REACT_NATIVE_DEBUG`. - Optimized builds also apply the Hermes opt mode. - The coverage modes already set the dev/opt build mode, so the explicit build mode modifier is no longer needed. - C++ coverage is merged with the LLVM tools that match the compiler used by the new modes. - `ReactHost` installs the TurboModule binding through the runtime-aware provider overload, since the macOS build treats the deprecated overload as an error. - This drops Windows support: there is no standard Windows build mode to replace the previous one, so the runner now throws on Windows. Changelog: [Internal] Differential Revision: D131472773
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D131472773. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Build the Fantom native tester and Hermes compiler with the standard Linux and macOS build modes instead of the previous per-platform mode set, matching how other internal test runners build their native binaries.
dev-nosan,opt,dev-asan,dev-tsan,dev-covandopt-covmodes, linked statically because the runner copies the binaries out of the build output directory.REACT_NATIVE_DEBUG.ReactHostinstalls the TurboModule binding through the runtime-aware provider overload, since the macOS build treats the deprecated overload as an error.Changelog: [Internal]
Differential Revision: D131472773