Repository navigation
Conversation
huntie
marked this pull request as ready for review
November 12, 2026 14:59
Collaborator
Author
|
@huntie-bot If merged before Monday, pick to 0.88 and 0.89 — again citing via an |
cipolleschi
reviewed
Nov 12, 2026
Collaborator
Author
|
@cipolleschi Updated, thanks |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Follow-up to #59194, which pads the content container across the scrollable axis for every
contentInsetAdjustmentBehaviorexcept'never'.Motivation
Before this diff,
'automatic'and'scrollableAxes'did the same thing. UIKit's.automaticdiffers from.scrollableAxesonly by a backward-compatibility rule tied toautomaticallyAdjustsScrollViewInsets, deprecated since iOS 11.This diff
Pad across the scrollable axis for
'automatic'and'always'only, so'scrollableAxes'applies the safe area insets along the scrollable axis alone, as its name and UIKit's.scrollableAxessay.'never''scrollableAxes''automatic''always''scrollableAxes'becomes a plain UIKit passthrough, and the opt-out for apps that handle the side insets themselves.contentInsetAdjustmentBehaviordocs now describe each value.Changelog:
[Internal] - Narrows the cross-axis padding from #59194 to
'automatic'and'always'before releaseTest Plan
RNTester, ScrollView > Content Inset Adjustment Behavior, full screen modal, switching the behavior with the buttons at the top. Before is #59836; after is this PR, both built from source. These are unframed simulator captures.
scrollableAxes, beforeautomatic.scrollableAxesscrollableAxes, beforeautomaticalwaysℹ️ Switching between the values on a running screen updates the layout in both directions.