Skip to content

Re-enable visual regression checks on PRs - #59970

Open
robhogan wants to merge 1 commit into
mainfrom
robhogan/visual-pr-checks
Open

robhogan wants to merge 1 commit into
mainfrom
robhogan/visual-pr-checks

Conversation

@robhogan

Copy link
Copy Markdown
Collaborator

This reverts #59629, which paused RNTester visual regression checks on PRs because of false positives.

Since retakes landed in #59408, 1 of 106 main reports (7-12 Nov) had a difference - a flake in button/disabled/default on an unrelated SwiftPM change. Before retakes it was ~20%.

Changelog: [Internal]

Test plan:
A clean reverse of #59629. Figures are from main's reports in the visual testing bucket.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2026
@robhogan
robhogan requested a review from cortinico November 12, 2026 14:16
@robhogan
robhogan added this pull request to stack #59971 November 12, 2026 14:16
@robhogan
robhogan force-pushed the robhogan/visual-pr-checks branch 2 times, most recently from 0838711 to 28dad04 Compare November 12, 2026 15:34
@robhogan
robhogan force-pushed the robhogan/visual-pr-checks branch from 28dad04 to 6af532d Compare November 12, 2026 15:35
Base automatically changed from robhogan/upload-test-results to main November 12, 2026 17:03
Reverts #59629, so RNTester visual captures and comparisons run on pull requests again, including from forks. Since retakes (#59408) landed, 1 of 106 `main` reports between 2026-11-07 and 2026-11-12 had a difference, a flake in `button/disabled/default`.

Changelog: [Internal]
@robhogan
robhogan force-pushed the robhogan/visual-pr-checks branch from 6af532d to af493f0 Compare November 12, 2026 17:03
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants