Repository navigation
Deprecate Button - #59960
Open
zoontek wants to merge 3 commits into
Open
Deprecate Button#59960zoontek wants to merge 3 commits into
zoontek wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Deprecates
Buttonas part of the effort to keep core lean. It offers very little customization, and you can build an equivalent button withPressable. It could easily be replaced by a documentation page with some code (ping @Simek).For an example with a design similar to
Button:Changelog:
[GENERAL] [DEPRECATED] - Deprecate
Button, build your own button withPressableinsteadTest Plan:
deprecatedshows a strikethrough onButtonin editors.Buttonlogs the deprecation warning once.yarn flow-check: 0 errors.yarn build-types:ReactNativeApi.d.tsis unchanged.yarn fantom packages/react-native/Libraries/Components/__tests__/Button-itest.js: 10/10 pass.