Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ConcreteShadowNode::getConcreteSharedProps()returnedconst std::shared_ptr<const ConcreteProps> &to the result ofstd::static_pointer_cast, which is a temporary, so every caller got a reference to ashared_ptrthat was already destroyed. It now returns theshared_ptrby value. Callers that copy the result, likeauto props = node.getConcreteSharedProps(), don't need to change. I regenerated the C++ API snapshots for the new signature.Fixes #59944
Changelog:
[GENERAL] [FIXED] -
ConcreteShadowNode::getConcreteSharedProps()no longer returns a dangling referenceTest Plan:
I compiled the reproducer from the issue against
ConcreteShadowNode.hwith clang and-Wreturn-stack-address. Before the change, clang warns "returning reference to local temporary object" atConcreteShadowNode.h:147. After the change there is no warning. I ranpython -m scripts.cxx-api.parserand the only change to theConcreteShadowNodesnapshot entries is thegetConcreteSharedProps()line.