Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Appearance.setColorScheme()updates the cached scheme thatgetColorScheme()returns, but it never emitschange. SouseColorScheme()keeps the old scheme until the nativeappearanceChangedevent arrives, and the same screen can show both schemes. NowsetColorScheme()emitschangewhen the scheme actually changes, and the native handler skips values that match the cache, so listeners don't get the same change twice.'auto'still updates when the native event arrives, because the system scheme isn't known in JS yet at that point.Fixes #59946
Changelog:
[General] [Fixed] -
Appearance.setColorScheme()now notifies change listeners, souseColorScheme()updates right awayTest Plan:
Added
Appearance-itest.jswith a fake native module. It checks thatsetColorScheme('light')calls the listener once, that the native echo doesn't call it again, and that a component usinguseColorScheme()re-renders withlightin the same task. I couldn't build the Fantom runner locally, so I checked the same cases under plain Jest: they fail on main and pass with the fix.yarn test packages/react-native/Librariespasses, and Flow, ESLint and Prettier are clean.