Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
reactnativeprefab in react-android ships the headers forview,image,root,textandtextinput, but notscrollview, even thoughlibreactnative.soalready containsrrc_scrollview. So a library building against the AAR can link ScrollView's shadow node and state but can't includeScrollViewComponentDescriptor.horScrollViewShadowNode.h. This addsrrc_scrollviewand itsplatform/androidfolder topreparePrefab, the same wayrrc_textinputis exported.Fixes #59929
Changelog:
[ANDROID] [FIXED] - Expose
rrc_scrollviewheaders via prefabTest Plan:
I don't have Java or the Android SDK on this machine, so I couldn't run
preparePrefabitself. Instead I took the prefab includes from the 0.89.0-rc.1 react-android AAR (plus the jsi and fbjni prefabs), copied the scrollview headers in with the same layout these twoPairs produce, and ranclang++ -fsyntax-onlyon a file that includesScrollViewComponentDescriptor.hand returnsconcreteComponentDescriptorProvider<ScrollViewComponentDescriptor>(). With the stock AAR it fails with'react/renderer/components/scrollview/ScrollViewComponentDescriptor.h' file not found; with the scrollview headers added it compiles.