Skip to content

Expose rrc_scrollview via prefab - #59954

Open
lazerg wants to merge 1 commit into
react:mainfrom
lazerg:fix/android-prefab-scrollview-headers
Open

lazerg wants to merge 1 commit into
react:mainfrom
lazerg:fix/android-prefab-scrollview-headers

Conversation

@lazerg

@lazerg lazerg commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Summary:

The reactnative prefab in react-android ships the headers for view, image, root, text and textinput, but not scrollview, even though libreactnative.so already contains rrc_scrollview. So a library building against the AAR can link ScrollView's shadow node and state but can't include ScrollViewComponentDescriptor.h or ScrollViewShadowNode.h. This adds rrc_scrollview and its platform/android folder to preparePrefab, the same way rrc_textinput is exported.

Fixes #59929

Changelog:

[ANDROID] [FIXED] - Expose rrc_scrollview headers via prefab

Test Plan:

I don't have Java or the Android SDK on this machine, so I couldn't run preparePrefab itself. Instead I took the prefab includes from the 0.89.0-rc.1 react-android AAR (plus the jsi and fbjni prefabs), copied the scrollview headers in with the same layout these two Pairs produce, and ran clang++ -fsyntax-only on a file that includes ScrollViewComponentDescriptor.h and returns concreteComponentDescriptorProvider<ScrollViewComponentDescriptor>(). With the stock AAR it fails with 'react/renderer/components/scrollview/ScrollViewComponentDescriptor.h' file not found; with the scrollview headers added it compiles.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] react-android's prefab has no react/renderer/components/scrollview headers, so a library cannot include ScrollView's component descriptor

1 participant