Repository navigation
Fix RNTester image loader test compilation - #59852
Merged
meta-codesync[bot] merged 1 commit intoNov 9, 2026
Merged
Conversation
javache
approved these changes
Nov 9, 2026
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D130637311. |
Collaborator
|
This pull request was successfully merged by @fairysword in 880b108 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Building the RNTester iOS unit-test target fails in
RCTImageLoaderTests.mwithexpected function body after function declarator.#59433 removed
RCTImageLoaderHelpers.hand the bridge-dependent image-loader tests, but left four invocations ofRCTDefineImageURLLoaderandRCTDefineImageDecoder. Remove these stale invocations so the remainingRCTImageLoaderCacheTestscan compile.Changelog:
[INTERNAL] [FIXED] - Fix RNTester iOS unit-test compilation after removal of the image-loader test helpers.
Test Plan:
Reproduced on main at
f480836ad8e, using Xcode 27.2 and an iPhone 18 Pro simulator running iOS 27.0. With RNTester's CocoaPods dependencies installed, ran the same command before and after the change, from the repository root:RCTImageLoaderTests.m.RNTesterUnitTeststarget compiles, andtestCachedImagePreservesNaturalSizeWhenNotClippedpasses: 1 test, 0 failures.The repository's formatting check also passes: