Skip to content

Fix RNTester image loader test compilation - #59852

Merged
meta-codesync[bot] merged 1 commit into
react:mainfrom
fairysword:fix/ios-image-loader-test-build
Nov 9, 2026
Merged

meta-codesync[bot] merged 1 commit into
react:mainfrom
fairysword:fix/ios-image-loader-test-build

Conversation

@fairysword

Copy link
Copy Markdown
Contributor

Summary:

Building the RNTester iOS unit-test target fails in RCTImageLoaderTests.m with expected function body after function declarator.

#59433 removed RCTImageLoaderHelpers.h and the bridge-dependent image-loader tests, but left four invocations of RCTDefineImageURLLoader and RCTDefineImageDecoder. Remove these stale invocations so the remaining RCTImageLoaderCacheTests can compile.

Changelog:

[INTERNAL] [FIXED] - Fix RNTester iOS unit-test compilation after removal of the image-loader test helpers.

Test Plan:

Reproduced on main at f480836ad8e, using Xcode 27.2 and an iPhone 18 Pro simulator running iOS 27.0. With RNTester's CocoaPods dependencies installed, ran the same command before and after the change, from the repository root:

xcodebuild test \
  -workspace packages/rn-tester/RNTesterPods.xcworkspace \
  -scheme RNTester \
  -configuration Debug \
  -destination 'platform=iOS Simulator,name=iPhone 18 Pro,OS=27.0' \
  -only-testing:RNTesterUnitTests/RCTImageLoaderCacheTests \
  -derivedDataPath build/image-loader-test-build/DerivedData \
  -jobs 6 \
  -parallel-testing-enabled NO \
  -disableAutomaticPackageResolution \
  CODE_SIGNING_ALLOWED=NO
  • Before: compilation fails at the stale macro invocations in RCTImageLoaderTests.m.
  • After: the RNTesterUnitTests target compiles, and testCachedImagePreservesNaturalSizeWhenNotClipped passes: 1 test, 0 failures.

The repository's formatting check also passes:

node scripts/clang-format.js --check packages/rn-tester/RNTesterUnitTests/RCTImageLoaderTests.m

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 7, 2026
@meta-codesync

meta-codesync Bot commented Nov 9, 2026

Copy link
Copy Markdown

@javache has imported this pull request. If you are a Meta employee, you can view this in D130637311.

@meta-codesync
meta-codesync Bot merged commit 880b108 into react:main Nov 9, 2026
92 checks passed
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @fairysword in 880b108

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants