Repository navigation
Skip the iOS ScrollView clip walk when no view clips its subviews - #59284
hryhoriiK97 wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
javache
left a comment
There was a problem hiding this comment.
I'm not a fan of using global state for this.
The subview clip pass should be shallow and only consider the children of the scrollview itself. Could we track this locally inside the scrollview's (content view?)?
|
Thanks @javache! I tried tracking it on the content view, but the pass can't be shallow today: a Options:
Which would you prefer? |
|
@javache any thoughts on the two options above? I re-measured on an iPhone: this walk is still ~30% of the main thread while scrolling a FlatList. Happy to go with whichever you prefer. |
Replace the global count of views with `removeClippedSubviews` with a weak set on each ScrollView. A view with the prop on registers with its nearest ScrollView while it is in a window, and unregisters when it leaves the window, turns the prop off or is recycled. A ScrollView skips its clipping pass while it is in a window and has no such views; outside a window it keeps walking, since its content can be mounted before it is shown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@javache I've tried to implement a new approach based on your suggestion, but I didn't make the walk shallow. Each ScrollView now tracks the views with removeClippedSubviews inside it and skips the walk when there are none, so no global state. The walk stays deep because it's what mounts the visible children of clipping views, also nested ones. Happy to make it shallow as a follow-up if you prefer. |
…회하지 않게 한다 (#15) * Fix iOS removeClippedSubviews being lost on recycled views (react#58915) Summary: On iOS, `prepareForRecycle` resets `_removeClippedSubviews` to `NO` but keeps `_props`, and `updateProps:oldProps:` only set the flag when `removeClippedSubviews` differed from `_props`. So a recycled view whose previous props also had `removeClippedSubviews` never turned clipping back on, and a remounted `ScrollView`/`FlatList` kept every row attached. This compares against `_removeClippedSubviews` itself, and adds a test. Fixes react#58914. Repro: https://github.com/mozzius/view-remove-clipped-subviews-recycle-repro ## Changelog: [IOS] [FIXED] - removeClippedSubviews is kept on recycled views Pull Request resolved: react#58915 Test Plan: In the repro (a `ScrollView` with `removeClippedSubviews` and 100 rows, unmounted and mounted again), the recycled content view keeps all 100/100 rows attached on every remount without this change (7/7, including 3/3 on unmodified 0.87.1), and 7/100 with it (3/3), the same as on first mount. The new `RCTViewComponentViewTests` case, run inside the repro app against 0.87.1 built from source, fails without the change and passes with it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed By: sammy-SC Differential Revision: D123878627 Pulled By: cipolleschi fbshipit-source-id: 21d792698d74805f61a9a93f5b944d8f5abcd7f3 (cherry picked from commit ff78e95) * fix(scatterlab): removeClippedSubviews 를 켠 뷰가 없으면 ScrollView 가 콘텐츠를 순회하지 않게 한다 iOS 의 `RCTScrollViewComponentView` 는 mounting transaction 이 끝날 때마다, 그리고 스크롤이 44pt 움직일 때마다 `_remountChildren` 으로 콘텐츠 전체를 재귀 순회한다. 순회가 실제로 일을 하는 곳은 `removeClippedSubviews` 가 켜진 `RCTViewComponentView` 뿐이고, 나머지 뷰는 rect 를 변환해 자식에게 넘기기만 한다. 옵저버 통지는 surface 의 모든 ScrollView 로 가므로, 그 prop 을 켠 뷰가 하나도 없는 앱은 커밋마다 마운트된 ScrollView 전부의 서브트리를 헛돈다. `RCTViewComponentView` 가 `_removeClippedSubviews` 가 켜진 살아 있는 뷰 수를 세고, `_remountChildren` 은 그 수가 0 이면 반환한다. 0 이 아니면 지금과 똑같이 순회한다. - 카운터는 props 가 아니라 플래그 자체의 전이를 따른다. 플래그를 바꾸는 두 곳(`updateProps`, `prepareForRecycle`)이 `RCTSetRemoveClippedSubviews` 하나를 거치고, 켜진 채 해제되는 뷰는 `dealloc` 이 뺀다. `prepareForRecycle` 은 플래그만 내리고 `_props` 는 남기므로, props 기준으로 세면 재활용된 뷰를 두 번 빼게 된다. 수가 실제보다 작으면 clipping 뷰의 자식이 화면에 붙지 않는다. - 가드는 `_remountChildren` 에만 둔다. `_remountChildrenIfNeeded` 의 `_contentOffsetWhenClipped` 갱신은 그대로라, 수가 0 인 동안 건너뛴 순회가 아무것도 바꾸지 않는다는 것만으로 이전과 상태가 같다. - 카운터는 `RCTViewComponentView.mm` 한 곳에 `std::atomic` 으로 두고 함수로 읽는다. 상류 react#59284(open)가 같은 목적이다. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * test(scatterlab): 클리핑 뷰 카운터와 ScrollView 순회 가드를 검증한다 - 낡은 props 를 가진 재활용 뷰가 카운터를 두 번 내리지 않는다. - 같은 값 반복·이중 `prepareForRecycle`·켜진 채 `dealloc` 뒤에 카운터가 제자리로 온다. - 카운터가 0 이면 `_remountChildren` 이 순회하지 않고, 다른 ScrollView 에 속한 뷰가 `removeClippedSubviews` 를 켜면 순회한다. - clipping 뷰에 새로 마운트된 자식 중 보이는 것은 ScrollView 순회가 붙인다. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * chore(scatterlab): 클리핑 순회 가드와 상류 react#58915 가 건드린 파일을 허용 목록에 올린다 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> * test(scatterlab): 순회 생략 테스트의 카운터 0 전제에 이유와 실패 메시지를 붙인다 순회 생략은 프로세스에 clipping 뷰가 하나도 없을 때만 관찰되므로 baseline 이 아니라 0 을 요구한다. 전제가 깨지면 원인이 바로 보이도록 메시지를 단다. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Summary:
RCTScrollViewComponentViewupdates clipped subviews in_remountChildrenby callingupdateClippedSubviewsWithClipRect:relativeToView:on its scroll view, after every mounting transaction and whenever the content offset has moved by more thankClippingLeewaywhile scrolling. The call walks every view in the scroll view's content. Only anRCTViewComponentViewwithremoveClippedSubviewsacts on it (it mounts and unmounts its children); every other view converts the rect and forwards it to its subviews.Current behavior.
removeClippedSubviewsis off by default on iOS, so in most apps no view acts on the walk, but every ScrollView still runs it on every few points of scrolling. In RNTester, this walk is the largest main-thread cost while scrolling: from a sixth to almost half of the main thread's time on the screens below.With this change.
RCTViewComponentViewkeeps a count of live views withremoveClippedSubviewson. It is updated when the prop changes, when a view is recycled and when it is deallocated, all on the main thread._remountChildrenreturns early while the count is 0. When any view hasremoveClippedSubviewson, the walk runs as before. Turning the prop off doesn't depend on the walk either: the view remounts all its children as soon as the prop changes.Changelog:
[IOS] [CHANGED] - A ScrollView no longer walks its content to update clipped subviews while no view has
removeClippedSubviewsonTest Plan:
clang-format --dry-run --Werroron the changed files passes.RCTViewComponentViewTests: all 24 tests pass on an iOS simulator. These tests are part of React-RCTFabric's test spec, which RNTester doesn't integrate, so I ran them by adding the file to theRNTesterUnitTeststarget locally (xcodebuild test -scheme RNTesterUnitTests -only-testing:RNTesterUnitTests/RCTViewComponentViewTests). The two new tests check that the count followsremoveClippedSubviewsacross two views without counting a view twice, and that recycling and deallocating a clipping view take it off the count. With the decrement indeallocremoved, the second test fails.xcodebuildin Release and run on a physical iPhone 15 Pro (iOS 26.6.1).removeClippedSubviewson, there were 0 mismatches over 102,997 walks (ScrollViewExample 89,199, TextExample 11,799, FlatList basic 1,999). In a screen that turnsremoveClippedSubviewson and off twice, with views mounted and unmounted in between, the count returned to 0 each time with 0 mismatches.removeClippedSubviewsWith the change, the walk took 0 ms on every screen. SectionList is mostly bound by the JS thread, and its main-thread total varied by ±10% between launches of the same arm.
removeClippedSubviewsviewWith a clipping view present, both arms run the same walk and the only added work is one comparison per walk; the ranges overlap and the difference between launches comes from the flings.
🤖 Generated with Claude Code