Repository navigation
Add enableMountingCoordinatorPullModelAndroid feature flag (#57581) - #57581
Closed
bartlomiejbloniarz wants to merge 1 commit into
Closed
bartlomiejbloniarz wants to merge 1 commit into
bartlomiejbloniarz wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112309049. |
bartlomiejbloniarz
force-pushed
the
export-D112309049
branch
from
July 23, 2026 09:09
5b50ea0 to
ae2d473
Compare
bartlomiejbloniarz
added a commit
that referenced
this pull request
Jul 23, 2026
Summary: Pull Request resolved: #57581 Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049
bartlomiejbloniarz
force-pushed
the
export-D112309049
branch
from
July 23, 2026 09:25
ae2d473 to
9823a2a
Compare
meta-codesync
Bot
changed the title
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
Summary: Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049
meta-codesync
Bot
force-pushed
the
export-D112309049
branch
from
July 24, 2026 12:51
9823a2a to
72cf5ad
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
Summary: Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049
bartlomiejbloniarz
added a commit
that referenced
this pull request
Jul 24, 2026
Summary: Pull Request resolved: #57581 Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049
bartlomiejbloniarz
force-pushed
the
export-D112309049
branch
from
July 24, 2026 13:07
72cf5ad to
10965c6
Compare
bartlomiejbloniarz
added a commit
that referenced
this pull request
Jul 27, 2026
Summary: Pull Request resolved: #57581 Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049
bartlomiejbloniarz
force-pushed
the
export-D112309049
branch
from
July 27, 2026 07:41
10965c6 to
df2d5e7
Compare
Summary: Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049
meta-codesync
Bot
force-pushed
the
export-D112309049
branch
from
July 27, 2026 10:27
df2d5e7 to
fa6f08e
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 27, 2026
Summary: Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049
bartlomiejbloniarz
added a commit
that referenced
this pull request
Jul 27, 2026
Summary: Pull Request resolved: #57581 Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049
|
This pull request has been merged in ece0efe. |
piaskowyk
added a commit
to discord/react-native
that referenced
this pull request
Sep 10, 2026
…), defaulted on (#48) * Add enableMountingCoordinatorPullModelAndroid feature flag (react#57581) Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only - no behavior change. Cherry-pick of react/react-native@ece0efe. The generated feature flag files conflicted because this fork's flag set has diverged from upstream, so they were regenerated from the config with `yarn featureflags` instead of being merged by hand. Co-authored-by: Cursor <cursoragent@cursor.com> * Default enableMountingCoordinatorPullModelAndroid to true Flip the flag's defaultValue to true and regenerate the feature-flag boilerplate with `yarn featureflags --update`. The config's own metadata already declared expectedReleaseValue: true. Neither app-side provider overrides the flag, so the default applies directly: ReactNativeNewArchitectureFeatureFlagsDefaults (Android) and ReactNativeFeatureFlagsOverridesOSSStable (iOS) both inherit it. Note: this is inert on this branch. The flag has no consumers here or upstream at ece0efe -- that commit only defines it, and the migration it gates (PullTransactionMountItem enqueued in MountItemDispatcher, so the UI thread pulls the transaction instead of the commit thread building the batch in schedulerShouldRenderTransactions) lands in later upstream commits that are not cherry-picked here. Setting true now records intent so the path is on once the implementation arrives. This is a separate mechanism from usePullModelOnAndroid, which this fork already defaults to true and which does have consumers in FabricUIManagerBinding.cpp and FabricUIManager.java. Upstream has since removed that flag, having graduated it. Before the implementation is backported, check the dependencies named in the flag description: enableAccumulatedUpdatesInRawPropsAndroid is already true, but enableExclusivePropsUpdateAndroid and enablePropsUpdateReconciliationAndroid are both still false, and the latter two are required when Props 2.0 is in use. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Dawid Małecki <maleckidawid@meta.com> Co-authored-by: Cursor <cursoragent@cursor.com>
piaskowyk
added a commit
to discord/react-native
that referenced
this pull request
Oct 13, 2026
…), defaulted on (#48) * Add enableMountingCoordinatorPullModelAndroid feature flag (react#57581) Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only - no behavior change. Cherry-pick of react/react-native@ece0efe. The generated feature flag files conflicted because this fork's flag set has diverged from upstream, so they were regenerated from the config with `yarn featureflags` instead of being merged by hand. Co-authored-by: Cursor <cursoragent@cursor.com> * Default enableMountingCoordinatorPullModelAndroid to true Flip the flag's defaultValue to true and regenerate the feature-flag boilerplate with `yarn featureflags --update`. The config's own metadata already declared expectedReleaseValue: true. Neither app-side provider overrides the flag, so the default applies directly: ReactNativeNewArchitectureFeatureFlagsDefaults (Android) and ReactNativeFeatureFlagsOverridesOSSStable (iOS) both inherit it. Note: this is inert on this branch. The flag has no consumers here or upstream at ece0efe -- that commit only defines it, and the migration it gates (PullTransactionMountItem enqueued in MountItemDispatcher, so the UI thread pulls the transaction instead of the commit thread building the batch in schedulerShouldRenderTransactions) lands in later upstream commits that are not cherry-picked here. Setting true now records intent so the path is on once the implementation arrives. This is a separate mechanism from usePullModelOnAndroid, which this fork already defaults to true and which does have consumers in FabricUIManagerBinding.cpp and FabricUIManager.java. Upstream has since removed that flag, having graduated it. Before the implementation is backported, check the dependencies named in the flag description: enableAccumulatedUpdatesInRawPropsAndroid is already true, but enableExclusivePropsUpdateAndroid and enablePropsUpdateReconciliationAndroid are both still false, and the latter two are required when Props 2.0 is in use. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Dawid Małecki <maleckidawid@meta.com> Co-authored-by: Cursor <cursoragent@cursor.com>
piaskowyk
pushed a commit
to discord/react-native
that referenced
this pull request
Oct 20, 2026
Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only - no behavior change. Cherry-pick of react/react-native@ece0efe. The generated feature flag files conflicted because this fork's flag set has diverged from upstream, so they were regenerated from the config with `yarn featureflags` instead of being merged by hand. Co-authored-by: Cursor <cursoragent@cursor.com>
tvinhas
pushed a commit
to tvinhas/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#57581 Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change. ## Changelog: [Android] [Added] - Add `enableMountingCoordinatorPullModelAndroid` feature flag Reviewed By: rubennorte Differential Revision: D112309049 fbshipit-source-id: 8bc6389a87feca57269ba1b17abde012e183a827
delekta
added a commit
to discord/react-native
that referenced
this pull request
Nov 4, 2026
* Revert "[Android] shadow-tree commit-lifecycle hooks (react#100)" This reverts commit 9eee718. The shadowTreeCommitSucceeded / shadowTreeCommitFinalized hooks existed only to make Reanimated's props-registry equality eviction race-free. That eviction turned out to be performance neutral and has been removed from the Reanimated fork, so nothing overrides these hooks anymore and the fork can drop the divergence from upstream in ShadowTree, ShadowTreeDelegate, UIManager and UIManagerCommitHook. Also restores the configureEventEmitterCallback() call in SampleTurboModuleSpec.cpp, which that commit had incidentally commented out. Co-authored-by: Cursor <cursoragent@cursor.com> * Add enableMountingCoordinatorPullModelAndroid feature flag (react#57581) Adds the `enableMountingCoordinatorPullModelAndroid` experiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only - no behavior change. Cherry-pick of react/react-native@ece0efe. The generated feature flag files conflicted because this fork's flag set has diverged from upstream, so they were regenerated from the config with `yarn featureflags` instead of being merged by hand. Co-authored-by: Cursor <cursoragent@cursor.com> * Default enableMountingCoordinatorPullModelAndroid to true Flip the flag's defaultValue to true and regenerate the feature-flag boilerplate with `yarn featureflags --update`. The config's own metadata already declared expectedReleaseValue: true. Neither app-side provider overrides the flag, so the default applies directly: ReactNativeNewArchitectureFeatureFlagsDefaults (Android) and ReactNativeFeatureFlagsOverridesOSSStable (iOS) both inherit it. Note: this is inert on this branch. The flag has no consumers here or upstream at ece0efe -- that commit only defines it, and the migration it gates (PullTransactionMountItem enqueued in MountItemDispatcher, so the UI thread pulls the transaction instead of the commit thread building the batch in schedulerShouldRenderTransactions) lands in later upstream commits that are not cherry-picked here. Setting true now records intent so the path is on once the implementation arrives. This is a separate mechanism from usePullModelOnAndroid, which this fork already defaults to true and which does have consumers in FabricUIManagerBinding.cpp and FabricUIManager.java. Upstream has since removed that flag, having graduated it. Before the implementation is backported, check the dependencies named in the flag description: enableAccumulatedUpdatesInRawPropsAndroid is already true, but enableExclusivePropsUpdateAndroid and enablePropsUpdateReconciliationAndroid are both still false, and the latter two are required when Props 2.0 is in use. Co-authored-by: Cursor <cursoragent@cursor.com> * [Discord] Enable preventShadowTreeCommitExhaustion by default Reanimated requires this React Native flag to be enabled before its own DISABLE_COMMIT_PAUSING_MECHANISM flag can be turned on safely; without it, React commits can be starved and the app becomes unresponsive. See https://docs.swmansion.com/react-native-reanimated/docs/guides/feature-flags/#disable_commit_pausing_mechanism Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@discordapp.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Dawid Małecki <maleckidawid@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds the
enableMountingCoordinatorPullModelAndroidexperiment flag (default off) that gates the Android pull-model mounting migration. Config entry plus regenerated accessors only — no behavior change.Changelog:
[Android] [Added] - Add
enableMountingCoordinatorPullModelAndroidfeature flagReviewed By: rubennorte
Differential Revision: D112309049