Repository navigation
Conversation
|
@robhogan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108986410. |
Summary: Reflecting the move to https://github.com/react/react-native , update references in first-party `package.json`s The `repository.url` field in particular is load-bearing for Trusted Publish. Changelog: [Internal] ___ Differential Revision: D108986410
meta-codesync
Bot
force-pushed
the
export-D108986410
branch
from
June 18, 2026 07:42
e32b640 to
e1e165f
Compare
|
This pull request has been merged in dcbd860. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 13, 2026
Summary: Automated update of React Native DevTools binaries Bundled changes: - **Desktop runtime:** Updated the standalone shell from Electron 39 to 43, including security updates. ([#57422](#57422), [#57338](#57338)) - **App menus:** Added Reload App, Reload DevTools, Quick Open, Command Palette, and Keyboard Shortcuts entries, with icons on macOS 26+. ([#57421](#57421)) - **macOS:** Added the macOS 26/27 app icon. ([#57310](#57310)) - **Automation:** Added support for Electron's `--remote-debugging-port` option. ([#58905](#58905)) - **Maintenance:** Migrated Node.js builtin imports to the `node:` scheme and updated package metadata to the `react` GitHub organization. ([#57611](#57611), [#57258](#57258)) bypass-github-export-checks Changelog: [General][Changed] - **React Native DevTools**: Upgrade the standalone app to Electron 43, add app-menu shortcuts, and add a macOS 26/27 icon Reviewed By: vzaidman Differential Revision: D124263283 fbshipit-source-id: 6b2a3eb729002ee9a11685b73ab5c0d0091600c7
meta-codesync Bot
pushed a commit
to meta/hermes
that referenced
this pull request
Nov 2, 2026
Summary: The repo is now `meta/hermes`. Two things on the React Native release path still assume `facebook/hermes`: 1. `rn-build-hermes.yml` guards its first job with `if: github.repository == 'facebook/hermes'`. That is false now, so `set_release_type` is skipped. The jobs that need it (`create-tag`, `build_android`, `publish`) are skipped too. A dispatch with `release-type=release` therefore builds as a dry run and publishes nothing. This happened on [run 41490254955](https://github.com/meta/hermes/actions/runs/41490254955), the cut of `260318099.0.6` for React Native 0.89 RC0: green, but no `hermes-v260318099.0.6` tag and nothing on npm. The last release that passed the guard was `260318099.0.5` on 2026-10-26 ([run 40331944867](https://github.com/meta/hermes/actions/runs/40331944867)). 2. `npm/hermes-compiler/package.json` still points `repository.url` at `facebook/hermes`. `hermes-compiler` is published with npm Trusted Publishing, which checks that `repository.url` matches the repo in the provenance. Runs now record `https://github.com/meta/hermes`, so the publish would fail once the guard is fixed. React Native hit the same thing after its rename and fixed it in react/react-native#57258. This changes both to `meta/hermes`. The release path still only switches on for a `workflow_dispatch` with `release-type=release`. Pull requests and the push from merging this stay dry runs. Before the next release, someone with owner access to `hermes-compiler` on npm needs to check that its trusted publisher points at `meta/hermes` and `rn-build-hermes.yml`. If it still names `facebook/hermes`, the publish fails even with this change. `static_h`, `main` and `250829098.0.0-stable` have the same guard and `repository.url`. They need the same fix. Pull Request resolved: #2281 Test Plan: - In run 41490254955, `set_release_type`, `create-tag`, `build_android` and `publish` were all skipped while every build job succeeded. That is what the guard causes. - This PR's first run ([run 41507807488](https://github.com/meta/hermes/actions/runs/41507807488)) shows the guard fixed. `set_release_type` runs and picks `dry-run`. `create-tag / publish` runs with `release-type: dry-run`. - The `repository.url` change can't be tested from a PR, since a dry run doesn't publish. The `260318099.0.5` publish had `git+ssh://git@github.com/facebook/hermes.git` with provenance from `https://github.com/facebook/hermes`, so npm accepted that format when the names matched. This keeps the format and only changes the org name. - After it lands, re-dispatch `RN Build Static Hermes` on this branch with `release-type=release` and `update-latest-v1=true`. The branch still names `260318099.0.6`, so that publishes it. Reviewed By: lavenzg Differential Revision: D129139155 Pulled By: fabriziocucci fbshipit-source-id: d6aa888a358cbb6fec2351e8d414b388facb5aae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reflecting the move to https://github.com/react/react-native , update references in first-party
package.jsonsThe
repository.urlfield in particular is load-bearing for Trusted Publish.Changelog: [Internal]
Differential Revision: D108986410