[kelset]

Summary

Node 16 has been the LTS for quite some time now (Oct 2021), so this PR just wants to bring the RN OSS CI up to speed.

(I realized that this was needed while doing the same for macos microsoft#997)

Changelog

[General] [Changed] - Breaking: moving minimum version of Node expected to 14, and move CI to current LTS(16).

Test Plan

CI itself is the test 🤣 locally no significant changes were experienced.

[facebook-github-bot]

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[NickGerleman]

This will create a warning or error for users of RN with Node 12. Is it okay to make the breaking change yet?

[Saadnajmi]

Also, why 14 and not 16?

[kelset]

@NickGerleman I think it's ok to make it a breaking change, folks should be on current LTS (so 16).

@Saadnajmi it's 14 because on CircleCI we also have a job that tests against the previous LTS (14) hence why the requirement. You can see me bumping that nodeprevlts in this PR

[cortinico]

@NickGerleman I think it's ok to make it a breaking change, folks should be on current LTS (so 16).

Agree here. Plus the current Node version (non lts) is 17.
I think it's totally ok to drop Node 12 (maybe we should add a note in the Changelog for this).

[kelset]

yeah let me change the changelog entry

[ShikaSD]

Seems like the changelog entry didn't sync properly, we might need to update this separately when building the changelog

[kelset]

@ShikaSD interesting - is this because I changed the text of the PR body after the import process was started?

[ShikaSD]

I think we landed the previous version internally, so we didn't re-import the description

[kelset]

gotcha - makes sense.

Change looks go to me 👍 You can disregard the internal failure as it's an unrelated warning (that gets exported as a error on Github Status).

This pull request was successfully merged by @kelset in f1488db.

^{When will my fix make it into a release? | Upcoming Releases}