APK size got increased almost double after upgrading to RN 0.66.0 #32463

Activity

1. ursnj

   added

   Needs: Triage 🔍

   on Oct 22, 2021
2. react-native-bot

   added

   Needs: Author Feedback

   Needs: Environment InfoPlease run `react-native info` and edit your issue with that command's output.Please run `react-native info` and edit your issue with that command's output.

   and removed

   Needs: Triage 🔍

   on Oct 22, 2021
3. github-actions commented on Oct 22, 2021

   

   github-actionsBot

   on Oct 22, 2021

   More actions

   ⚠️	Missing Environment Information
   ℹ️	Your issue may be missing information about your development environment. You can obtain the missing information by running react-native info in a console.
4. Smiche commented on Nov 9, 2021

   

   Smiche

   on Nov 9, 2021

   More actions

   Similar experience here after upgrading from react-native 0.64 to 0.66
   
5. react-native-bot

   removed

   Needs: Environment InfoPlease run `react-native info` and edit your issue with that command's output.Please run `react-native info` and edit your issue with that command's output.

   on Nov 9, 2021
6. cortinico commented on Nov 9, 2021

   

   cortinico

   on Nov 9, 2021

   Contributor

   More actions

   What's your minSdkVersion? By any chance have you bumped from 21 to 23?
7. Smiche commented on Nov 9, 2021

   

   Smiche

   on Nov 9, 2021

   More actions

   minSdkVersion 24 and have not changed it while upgrading react-native.
8. shubhamdeol commented on Nov 11, 2021

   

   shubhamdeol

   on Nov 11, 2021

   More actions

   I am also facing similar issue. App size on Playstore increased from 12 mb to 25 mb.
9. shubhamdeol commented on Nov 12, 2021

   

   shubhamdeol

   on Nov 12, 2021

   More actions

   @cortinico can it be due to all libraries staring to support api 30 from 29 ?
10. cortinico commented on Nov 12, 2021

    

    cortinico

    on Nov 12, 2021

    Contributor

    More actions

    So what could have happened is that in your bump, the minSdk version got moved from 21 to 23 (or above).
    The change could have been imposed by one of the transitive dependency in your project.

    React Native is specifying minSdkVersion 21, but if any of your library or your project is specifying a higher number, that will prevail.

    Specifically with api lvl 23, the native libraries are uncompressed in the APK, resulting in the an apparent bigger size of the APK (see here https://stackoverflow.com/a/63417612).

    The best to investigate this is if someone could create a reproduce on Github, adding a base commit on RN 0.64 and a subsequent commit with the bump to 0.66. That would greatly help investigate what happened.

    👍React with 👍2Reacted by Shubham Choudhary and Rajendran Nadar
11. cortinico

    added

    Needs: ReproThis issue could be improved with a clear list of steps to reproduce the issue.This issue could be improved with a clear list of steps to reproduce the issue.

    Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

    on Nov 12, 2021
12. github-actions commented on Nov 12, 2021

    

    github-actionsBot

    on Nov 12, 2021

    More actions

    ⚠️	Missing Reproducible Example
    ℹ️	It looks like your issue is missing a reproducible example. Please provide a Snack or a repository that demonstrates the issue you are reporting in a minimal, complete, and reproducible manner.
13. 1 remaining item

    Load more

14. cortinico commented on Jan 6, 2022

    

    cortinico

    on Jan 6, 2022

    Contributor

    More actions

    To help better debug, attaching the screenshot of the diff in the size increase of libs.

    

    From which version are you migrating from @anirudhagarwal1
15. anirudhagarwal1 commented on Jan 6, 2022

    

    anirudhagarwal1

    on Jan 6, 2022

    More actions

    To help better debug, attaching the screenshot of the diff in the size increase of libs.
    

    From which version are you migrating from @anirudhagarwal1

    I am upgrading from 0.63.4.

    Also one more question. The above screenshot is of a release build, then why do I see some debug .so files(for ex: libhermes-executor-common-debug.so)? Is that expected?
16. liamjones commented on Jan 6, 2022

    

    liamjones

    on Jan 6, 2022

    Contributor

    More actions

    This is also what we experienced upgrading from 0.63.4 to 0.66.3 too - about 6MB of new libs (including hermes/debug ones in non-Hermes release builds).
17. cortinico commented on Jan 6, 2022

    

    cortinico

    on Jan 6, 2022

    Contributor

    More actions

    The above screenshot is of a release build, then why do I see some debug .so files(for ex: libhermes-executor-common-debug.so)? Is that expected?

    Nope is not. The react.gradle script has a specific section for removing the .so that are not relevant to your build. Specifically:

    https://github.com/facebook/react-native/blob/a03bd2f13ed9d20f4c82ae1e73a4afa281fe2e9a/react.gradle#L360-L379

    The best would be to try on an empty project on RN 0.66.0 and verify if it's working correctly or not.
18. liamjones commented on Jan 6, 2022

    

    liamjones

    on Jan 6, 2022

    Contributor

    More actions

    Yep, doesn't look like it's working:

     ~/code  npx react-native init RNReleaseTest                                                                                                                                                                                                                    ∞
    Need to install the following packages:
      react-native
    Ok to proceed? (y) y
    [snip]
     ~/code  cd RNReleaseTest                                                                                                                                                                                                                                           ∞
     ~/code/RNReleaseTest  cd android                                                                                                                                                                                                                                   ∞
     ~/code/RNReleaseTest/android  ./gradlew assembleRelease                                                                                                                                                                                                            ∞
    Starting a Gradle Daemon (subsequent builds will be faster)
    [snip]
    BUILD SUCCESSFUL in 1m 6s
    38 actionable tasks: 38 executed
     ~/code/RNReleaseTest/android  grep "enableHermes:" app/build.gradle                                                                                                                                                                                                ∞
        enableHermes: false,  // clean and rebuild if changing
     ~/code/RNReleaseTest/android  zip -sf app/build/outputs/apk/release/app-release.apk | grep libhermes                                                                                                                                                               ∞
      lib/arm64-v8a/libhermes-executor-common-debug.so
      lib/arm64-v8a/libhermes-executor-common-release.so
      lib/arm64-v8a/libhermes-executor-debug.so
      lib/arm64-v8a/libhermes-executor-release.so
      lib/arm64-v8a/libhermes-inspector.so
      lib/armeabi-v7a/libhermes-executor-common-debug.so
      lib/armeabi-v7a/libhermes-executor-common-release.so
      lib/armeabi-v7a/libhermes-executor-debug.so
      lib/armeabi-v7a/libhermes-executor-release.so
      lib/armeabi-v7a/libhermes-inspector.so
      lib/x86/libhermes-executor-common-debug.so
      lib/x86/libhermes-executor-common-release.so
      lib/x86/libhermes-executor-debug.so
      lib/x86/libhermes-executor-release.so
      lib/x86/libhermes-inspector.so
      lib/x86_64/libhermes-executor-common-debug.so
      lib/x86_64/libhermes-executor-common-release.so
      lib/x86_64/libhermes-executor-debug.so
      lib/x86_64/libhermes-executor-release.so
      lib/x86_64/libhermes-inspector.so
     ~/code/RNReleaseTest/android  zip -sf app/build/outputs/apk/release/app-release.apk | grep libjscexecutor                                                                                                                                                          ∞
      lib/arm64-v8a/libjscexecutor.so
      lib/armeabi-v7a/libjscexecutor.so
      lib/x86/libjscexecutor.so
      lib/x86_64/libjscexecutor.so
    
19. anirudhagarwal1 commented on Jan 6, 2022

    

    anirudhagarwal1

    on Jan 6, 2022

    More actions

    @cortinico Do you need anything else from my end to help you debug the issue?
20. cortinico commented on Jan 7, 2022

    

    cortinico

    on Jan 7, 2022

    Last edited by cortinico

    Contributor

    More actions

    @cortinico Do you need anything else from my end to help you debug the issue?

    Nope, thanks for the input 👍. I was able to reproduce, and the bug is effectively there on 0.66.0. I've also tested on 0.67.0-rc.6 and the regression got already fixed.

    From @liamjones command, running on 0.67:

    $ zip -sf android/app/build/outputs/apk/release/app-release.apk | grep libhermes
      lib/arm64-v8a/libhermes-executor-common-release.so
      lib/arm64-v8a/libhermes-executor-release.so
      lib/arm64-v8a/libhermes.so
      lib/armeabi-v7a/libhermes-executor-common-release.so
      lib/armeabi-v7a/libhermes-executor-release.so
      lib/armeabi-v7a/libhermes.so
      lib/x86/libhermes-executor-common-release.so
      lib/x86/libhermes-executor-release.so
      lib/x86/libhermes.so
      lib/x86_64/libhermes-executor-common-release.so
      lib/x86_64/libhermes-executor-release.so
      lib/x86_64/libhermes.so
    

    The fix is most likely this #32257 which haven't been included in 0.66.0. Given that 0.67 is really close to be released, I think we should be good to go with that.

    Should there be blockers for 0.67.0, we can consider backporting #32257 to a point release for 0.66.x

    Closing as this was essentially resolved. Feel free to re-open or comment if needed 👍

    EDIT: typo

    👍React with 👍1Reacted by Liam Jones
21. cortinico

    closed this as completedon Jan 7, 2022
22. ursnj commented on Feb 12, 2022

    

    ursnj

    on Feb 12, 2022

    Author

    More actions

    This issue not resolved in 0.67 also, im seeing same bundle size with newer version also.

    👍React with 👍4Reacted by Givi Tkemaladze, Mukhamed Khasanza, Quan Nguyen and JJSLIoT
23. github-actions

    added

    Needs: AttentionIssues where the author has responded to feedback.Issues where the author has responded to feedback.

    and removed

    Needs: Author Feedback

    on Feb 12, 2022
24. weihangChen commented on Feb 15, 2022

    

    weihangChen

    on Feb 15, 2022

    Last edited by weihangChen

    More actions

    after upgrading from 0.66 to 0.67 it went down for 30MB, but there is still a 40MB up compared to previous version. But I did have android minsdk bumped from 21 to 23, as others suggested, it also contributes to the increases of size
25. mokshmodi96 commented on Jun 6, 2022

    

    mokshmodi96

    on Jun 6, 2022

    Last edited by mokshmodi96

    More actions

    I bumped my minSdkVersion to 23 from 21 and apk size doubled but i found a workaround-ish on stackoverflow linked below here

    👍React with 👍2Reacted by RaghavRhythm and Mighty Software

    🚀React with 🚀2Reacted by RaghavRhythm and Sandeep Das
26. react

    locked as resolved and limited conversation to collaborators on Jan 7, 2023
27. react-native-bot

    added

    Resolution: LockedThis issue was locked by the bot.This issue was locked by the bot.

    on Jan 7, 2023