Repository navigation
[mypyc] Add primitives for int and bytes containment in bytes - #22409
Open
Jahongir-Qurbonov wants to merge 3 commits into
Open
Jahongir-Qurbonov wants to merge 3 commits into
Jahongir-Qurbonov wants to merge 3 commits into
Conversation
13 of 14 tasks
# Conflicts: # mypyc/test-data/run-bytes.test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add primitives for
x in b/x not in bwherebisbytesandxisintorbytes.Previously these used
PySequence_Contains. For abytesitem that is particularly slow, sincebytes.__contains__first tries to convert the item to an integer, which raises and clears aTypeError, and then acquires a buffer.int in bytes: for an exactbytesobject, a range check followed bymemchr. Out-of-range values raise the sameValueErroras CPython.bytes in bytes: if both are exactbytesobjects and the needle is at most 32 bytes long, search directly usingmemchr+memcmp. Longer needles fall back to the generic implementation, which has better worst-case behavior.__contains__) use the generic path.Tests compare the results against the generic implementation (through
Any) for all byte values, out-of-range and big ints, and all substrings (plus near-miss variants) of several haystacks.Micro-benchmark (compiled code, before -> after, Python 3.13):
int in bytes(3.2M checks): 0.025s -> 0.0086sbytes in bytes(3.2M checks): 0.49s -> 0.026sbytes in bytes(3.2M checks): 0.49s -> 0.039sPart of mypyc/mypyc#644.