Skip to content

Remove an unneeded call into OpenSSL - #6887

Merged
alex merged 1 commit into
masterfrom
alex-patch-1
May 16, 2018
Merged

alex merged 1 commit into
masterfrom
alex-patch-1

Conversation

@alex

@alex alex commented May 16, 2018

Copy link
Copy Markdown
Member

This call doesn't do anything, on every version of OpenSSL going back to forever the call to ERR_clear_error() calls ERR_get_state(), so it's always been a no-op.

@alex
alex merged commit 55e53c3 into master May 16, 2018
@alex
alex deleted the alex-patch-1 branch May 16, 2018 17:02
mozillazg pushed a commit to mozillazg/pypy that referenced this pull request May 16, 2018
This call doesn't do anything, on every version of OpenSSL going back to forever the call to ERR_clear_error() calls ERR_get_state(), so it's always been a no-op.

Same change for CPython: python/cpython#6887
mozillazg pushed a commit to mozillazg/pypy that referenced this pull request May 17, 2018
This call doesn't do anything, on every version of OpenSSL going back to forever the call to ERR_clear_error() calls ERR_get_state(), so it's always been a no-op.

Same change for CPython: python/cpython#6887
mehw added a commit to mehw/cpython that referenced this pull request Nov 6, 2026
Compilation tested with OpenSSL 4.1.0 on Gentoo GNU/Linux (amd64).

Upstream commit references:

Remove an unneeded call into OpenSSL (pythonGH-6887)
python@55e53c3

bpo-40457: Support OpenSSL without TLS 1.0/1.1 (pythonGH-19862)
python@6e8cda9

bpo-43669: PEP 644: Require OpenSSL 1.1.1 or newer (pythonGH-23014)
python@39258d3

pythongh-146207: Add support for OpenSSL 4.0.0 alpha1 (python#146217)
python@3364e7e

pythongh-159387: Fix TLS 1.0–1.2 availability detection with OpenSSL 4.0 (pythonGH-159388)
python@e7acd6a

pythongh-141801: Use accessors for ASN1_STRING fields in libssl
python@c41fce0

Remove SSLv2 support
openssl/openssl@45f55f6

Removes fixed version TLS methods
openssl/openssl@9a46c4c

Describe X509 constification and ASN1_STRING changes
openssl/openssl@c0f82d9

Constify X509_NAME
openssl/openssl@b0f2107

Make ASN1_STRING opaque
openssl/openssl@46dbd7f

Make ERR_STATE opaque and remove related deprecated functions
openssl/openssl@5c14539

Closes: https://bugs.gentoo.org/985562
Signed-off-by: Matthew White <mehw.is.me@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants