Repository navigation
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161657.
AF_VSOCKsockets currently force all options through VSOCK's 64-bit integer handling. This rejects valid bufferedSOL_SOCKEToptions such asSO_LINGERbefore the kernel sees them. Restrict the VSOCK-specific get/set branches tolevel == AF_VSOCK, so other option levels use the existing generic paths.Add a regression that adopts an owned, unconnected Unix socket FD with an explicit Python
AF_VSOCKfamily. It covers bufferedSO_LINGERget/set, ordinary integer options, and preservation of the 64-bit VSOCK conversion path without requiring a VSOCK device or VM.Validation: built a debug interpreter with
./configure --with-pydebug --without-ensurepipandmake -j2. The new regression reproduces the buffered get/set failures before the C change and passes after it. Existing socket-option get/set/error tests also pass. Ruff andmake patchcheckpass. Local test-module import probes were guarded, and syscall tracing confirmed that validation created no VSOCK endpoints and made no bind, connect, listen, or accept calls. The fulltest_socketsuite and hardware-backed VSOCK tests were not run locally.This contribution was prepared with AI assistance and independently reviewed for the scoped C change and regression.