Repository navigation
Conversation
bedevere-app
Bot
added
awaiting review
type-feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #161543, following @sobolevn's request and the feedback from the previous review.
The main change is to import
_wmilazily, soimport platformno longer has to load it upfront. I've also made sure failed queries aren't cached, added a test usingensure_lazy_imports, and included the suggested NEWS entry.I added a Windows-only guard around the lazy import. Without it, applications using a lazy import filter that rejects
_wmican fail to importplatformon non-Windows systems. I reproduced this on Linux and verified that the guard fixes it.On Windows 11, I measured
import platformgoing from 27.3 ms to 16.4 ms over 100 alternating runs. I also checked that the results returned byplatformremain unchanged.test_platformpasses on Windows and Linux, andtest_wmipasses on Windows (it's skipped on Linux).AI disclosure: I used GitHub Copilot to help with testing and benchmarking.