Skip to content

gh-161617: Fix test_clinic, test_tools, test_generated_cases with lazy imports - #161618

Open
sobolevn wants to merge 3 commits into
python:mainfrom
sobolevn:issue-161617
Open

gh-161617: Fix test_clinic, test_tools, test_generated_cases with lazy imports#161618
sobolevn wants to merge 3 commits into
python:mainfrom
sobolevn:issue-161617

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 8, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Looks like that my change to imports_under_tool also fixed other tests.
So, I removed them from the ignore as well.

@bedevere-app bedevere-app Bot mentioned this pull request Nov 8, 2026
Open
StanFromIreland
StanFromIreland reviewed Nov 8, 2026
View reviewed changes
Comment thread Lib/test/support/import_helper.py Resolved
StanFromIreland
StanFromIreland reviewed Nov 8, 2026
View reviewed changes
Comment thread Lib/test/test_tools/__init__.py
@@ -32,7 +32,7 @@ def skip_if_missing(tool=None):
@contextlib.contextmanager
def imports_under_tool(name, *subdirs):

@StanFromIreland StanFromIreland Nov 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, does it not make sense to do it here instead?

@sobolevn sobolevn Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, it might be required for other places that use DirsOnSysPath as well, since it is a broader API. We can alternatevly make a separate API called with forced_eager_imports(): and use it here. WDYT?

@sobolevn sobolevn Nov 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it is a better and more compsable API :)

@sobolevn sobolevn mentioned this pull request Nov 9, 2026
Open
@sobolevn

sobolevn commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

I also need this new context manager in #161660 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @StanFromIreland