Repository navigation
[3.13] gh-160506: Fix ntpath.realpath() for broken links via directory links (GH-160507) - #161028
Open
miss-islington wants to merge 4 commits into
Open
miss-islington wants to merge 4 commits into
miss-islington wants to merge 4 commits into
Conversation
… links (pythonGH-160507) Resolve the directory containing a broken relative symlink before joining the link target to it, so that '..' in the target is applied to the real directory. ANT-2026-27II3A20 (cherry picked from commit 65665a4) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
This was referenced Oct 31, 2026
github-project-automation
Bot
moved this from Todo
to Done
in Release and Deferred blockers 🚫
github-project-automation
Bot
moved this from Done
to In Progress
in Release and Deferred blockers 🚫
Before 3.15, tarfile keeps the '/' in symlink targets on Windows (pythongh-57911), so writing through the '../evil' link fails, as already handled in test_parent_symlink2.
Before 3.15, tarfile keeps the '/' in symlink targets on Windows (pythongh-57911), so the links it creates cannot be followed and realpath() fails on them. test_ntpath covers the fix on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the directory containing a broken relative symlink before
joining the link target to it, so that '..' in the target is applied
to the real directory.
ANT-2026-27II3A20
(cherry picked from commit 65665a4)
Co-authored-by: Gregory P. Smith 68491+gpshead@users.noreply.github.com
os.path.realpath()on Windows misresolves a broken symlink reached through a directory symlink #160506