Repository navigation
Add test for Argument Clinic converters #79759
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2018-12-24.16:41:25.367>
labels = ['3.7', '3.8', 'type-feature', 'tests', 'expert-argument-clinic']
title = 'Add test for Argument Clinic converters'
updated_at = <Date 2018-12-29.20:34:50.829>
user = 'https://github.com/serhiy-storchaka'bugs.python.org fields:
activity = <Date 2018-12-29.20:34:50.829>
actor = 'pablogsal'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests', 'Argument Clinic']
creation = <Date 2018-12-24.16:41:25.367>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 35578
keywords = ['patch', 'patch', 'patch']
message_count = 4.0
messages = ['332493', '332504', '332506', '332732']
nosy_count = 3.0
nosy_names = ['larry', 'serhiy.storchaka', 'pablogsal']
pr_nums = ['11306', '11306', '11306', '11311', '11311', '11311']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35578'
versions = ['Python 3.7', 'Python 3.8']
Activity
serhiy-storchaka commentedon Dec 24, 2018
Currently Argument Clinic converters are tested by running Argument Clinic on the CPython source tree. If it generates incorrect code, then it contains bugs. But not all combinations of standard converters and options are used in the stdlib.
The programming interface of Argument Clinic is complex, and it is hard to write tests for testing only specific functionality. The simplest way of testing Argument Clinic is to write a C file containing declarations and generated code for all test cases. Although this does not allow to test error cases.
The proposed PR adds Lib/test/clinic_test.c which contains tests for all standard converters. It will be extended in bpo-20180 (PR bpo-9828) and bpo-23867.
serhiy-storchaka commentedon Dec 25, 2018
New changeset 837c7dc by Serhiy Storchaka in branch 'master':
bpo-35578: Add an example file for testing Argument Clinic converters. (GH-11306)
837c7dc
serhiy-storchaka commentedon Dec 25, 2018
New changeset 74d914e by Serhiy Storchaka in branch '3.7':
[3.7] bpo-35578: Add an example file for testing Argument Clinic converters. (GH-11306) (GH-11311)
74d914e
pablogsal commentedon Dec 29, 2018
Is there anything left in this issue or we can close it?
erlend-aasland commentedon May 1, 2023
Tests for clinic converters were significantly improved in gh-96178. We can close this now.