Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions bench_runner/templates/_benchmark.src.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,12 @@ jobs:
run: |
# Another benchmarking task may have created results for the same
# commit while the above was running. This "magic" incantation means
# that any local results for this commit will override anything we
# just pulled in in that case.
git pull -s recursive -X ours --autostash --rebase
# that any local results for this commit will override anything that
# happened in the meantime.
# https://stackoverflow.com/questions/43770520/how-to-specify-default-merge-strategy-on-git-stash-pop
git stash
git pull -s recursive --rebase
git cherry-pick -n -m1 -Xtheirs stash

Copilot AI Jan 8, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'git cherry-pick -n -m1 -Xtheirs stash' is unusual and may not work as intended. Consider using 'git stash pop' or 'git stash apply' instead.

Suggested change
git cherry-pick -n -m1 -Xtheirs stash
git stash pop

Copilot uses AI. Check for mistakes.
- name: Add data to repo
if: ${{ steps.should_run.outputs.should_run != 'false' }}
uses: EndBug/add-and-commit@v9
Expand Down Expand Up @@ -227,9 +230,12 @@ jobs:
run: |
# Another benchmarking task may have created results for the same
# commit while the above was running. This "magic" incantation means
# that any local results for this commit will override anything we
# just pulled in in that case.
git pull -s recursive -X ours --autostash --rebase
# that any local results for this commit will override anything that
# happened in the meantime.
# https://stackoverflow.com/questions/43770520/how-to-specify-default-merge-strategy-on-git-stash-pop
git stash
git pull -s recursive --rebase
git cherry-pick -n -m1 -Xtheirs stash

Copilot AI Jan 8, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of 'git cherry-pick -n -m1 -Xtheirs stash' is unusual and may not work as intended. Consider using 'git stash pop' or 'git stash apply' instead.

Suggested change
git cherry-pick -n -m1 -Xtheirs stash
git stash pop

Copilot uses AI. Check for mistakes.
- name: Adding data to repo
if: ${{ steps.should_run.outputs.should_run != 'false' && !inputs.perf }}
uses: EndBug/add-and-commit@v9
Expand Down Expand Up @@ -321,9 +327,12 @@ jobs:
run: |
# Another benchmarking task may have created results for the same
# commit while the above was running. This "magic" incantation means
# that any local results for this commit will override anything we
# just pulled in in that case.
git pull -s recursive -X ours --autostash --rebase
# that any local results for this commit will override anything that
# happened in the meantime.
# https://stackoverflow.com/questions/43770520/how-to-specify-default-merge-strategy-on-git-stash-pop
git stash
git pull -s recursive --rebase
git cherry-pick -n -m1 -Xtheirs stash
- name: Add data to repo
if: ${{ steps.should_run.outputs.should_run != 'false' }}
uses: EndBug/add-and-commit@v9
Expand Down