Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated
Connectionfield lines are currently overwritten during both the server's request validation and the client's 101-response validation. A valid handshake containing:raises
RemoteProtocolError: Missing header, 'Connection: Upgrade'because only the final field's tokens are checked.Accumulate tokens from every field line, using the existing comma-list parser and case-insensitive
Upgradecheck. Missing headers and lists withoutUpgradecontinue to be rejected. This follows combined field-value handling in RFC 9110 §5.2–5.3 and the WebSocket handshake token requirement. The change is based directly on current main and is independent of #210.Validation on macOS arm64:
python -bb -m pytest; on 3.12 also--cov=wsproto --cov-report=term --cov-report=xml). Total line/branch coverage stays at 96.57%; all changed executable lines are covered.mypy src/(strict), Ruff check/format for the new test,make -C docs clean html,check-manifest,python -m build --outdir dist/, andtwine check dist/*passed.Other Python/platform combinations await upstream CI. Development groups were installed using
uv pip install -e . --group devin Python 3.12, avoiding the existing universal resolver conflict between Python 3.10 support and the Sphinx 8 documentation group; no dependency files changed.Prepared with OpenAI Codex automation. No human review is claimed.