[DawnofGenX]

Link to issue

Closes #5849

Description of change

The code generator wrote the optional FigureWidget import block (the try: import ... plus the missing_* fallback) into both plotly/graph_objs/__init__.py and plotly/graph_objects/__init__.py, leaving an identical block at the end of each generated file. graph_objects re-exports every other class from graph_objs — including Figure — and graph_objs already owns the optional import and the fallback, so the generator now emits the block only for graph_objs and adds ..graph_objs.FigureWidget to graph_objects' re-export list. The change is in codegen/__init__.py; plotly/graph_objects/__init__.py is regenerated (python commands.py codegen), not hand-edited.

Demo

N/A — no user-visible or visual change. Behaviour is unchanged: plotly.graph_objects.FigureWidget is the same object as plotly.graph_objs.FigureWidget, and still falls back to plotly.missing_anywidget.FigureWidget when ipywidgets is unavailable.

Testing strategy

Adds tests/test_core/test_figure_widget_backend/test_figurewidget_reexport.py, which asserts the three invariants: graph_objects.FigureWidget is graph_objs.FigureWidget, the forced-ipywidgets-failure fallback still resolves, and plotly/graph_objects/__init__.py contains no optional-ipywidgets import block of its own. The last assertion is the regression signal — it fails on unmodified main.

Additional information (optional)

Ran python commands.py codegen on the committed tree with the pinned ruff and it produces no diff, so the generated file and the generator agree.

Guidelines

• I have reviewed the pull request guidelines and the Code of Conduct and confirm that this PR follows them.
• I have added an entry to the changelog if needed (not required for documentation PRs).

[camdecoster]

Thanks for the update. Could you please make these changes?

[camdecoster]

Could you please remove this test? It seems like overkill.

[DawnofGenX]

Removed in 61bb49e. tests/test_core/test_figure_widget_backend/test_figurewidget_reexport.py is gone; the rest of the suite still passes (19 passed in tests/test_core/test_figure_widget_backend + tests/test_core/test_optional_imports).

[camdecoster]

Could you please revert these changes? This is an internal update and doesn't need a changelog entry.

[DawnofGenX]

Reverted in 61bb49e — CHANGELOG.md is back to upstream and no longer appears in the diff. One heads-up: the Check changelog workflow fails when a PR has no CHANGELOG change unless it carries the no-changelog label, and I can't add labels. Could you add it when you next look at this?

[camdecoster]

Let's simplify this a bit:

Suggested change

	graph_objects_rel_classes.append("..graph_objs.FigureWidget")
	graph_objects_rel_classes = [
	*("..graph_objs." + rel_path.split(".")[-1] for rel_path in datatype_rel_class_imports[()]),
	# graph_objs owns the optional ipywidgets import and the fallback
	"..graph_objs.FigureWidget",
	]

[DawnofGenX]

Applied in 61bb49e. ruff format --check (which CI runs over the whole repo) insists on wrapping the generator, so the committed form is:

    graph_objects_rel_classes = [
        *(
            "..graph_objs." + rel_path.split(".")[-1]
            for rel_path in datatype_rel_class_imports[()]
        ),
        # graph_objs owns the optional ipywidgets import and the fallback
        "..graph_objs.FigureWidget",
    ]

Same thing as your suggestion, just formatter-stable. ruff format --check codegen/__init__.py and ruff check codegen/__init__.py both pass, and running python commands.py codegen is a no-op on the tree.

[DawnofGenX]

All three review points are addressed in 61bb49e (rebased onto current main):

1. Deleted tests/test_core/test_figure_widget_backend/test_figurewidget_reexport.py.
2. Reverted the CHANGELOG.md entry — the PR diff is now only codegen/__init__.py and plotly/graph_objects/__init__.py.
3. Applied the suggested inline list form at codegen/__init__.py (the generator is wrapped because ruff format --check runs over the whole repo in CI).

Verification on the pushed head:

• ruff format --check / ruff check clean on the changed files
• python commands.py codegen is a no-op on the tree (no diff after regeneration)
• pytest tests/test_core/test_figure_widget_backend tests/test_core/test_optional_imports → 19 passed
• FigureWidget still resolves to plotly.graph_objs._figurewidget.FigureWidget, stays in graph_objs.__all__, and raises the anywidget ImportError when the optional dependency is missing

One thing I can't do myself: the Check changelog workflow will fail on this PR now that the changelog change is reverted, unless it gets the no-changelog label — only maintainers can add labels.

Could you take another look when you get a chance?