Repository navigation
Restore graph config shape check as standalone test (fixes #3735) - #4140
Open
Hayabusa-YL wants to merge 2 commits into
Open
Hayabusa-YL wants to merge 2 commits into
Hayabusa-YL wants to merge 2 commits into
Conversation
Restore the check_graph_config_shape assertion that was removed in PR plotly#3737 as its own dedicated test. Adds displayNotifier to the ignored config list since it was introduced in that PR but is not yet part of Plotly.PlotSchema. Closes plotly#3735
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Restores the \check_graph_config_shape\ assertion that was removed in PR #3737 as its own standalone test.
Changes
displayNotifierto Graph config #3737 but not yet in Plotly.PlotSchema)Closes #3735