Skip to content

Include property hooks in phpdbg opcode listings - #25366

Open
crystarm wants to merge 1 commit into
php:masterfrom
crystarm:fix/phpdbg-property-hook-opcodes
Open

crystarm wants to merge 1 commit into
php:masterfrom
crystarm:fix/phpdbg-property-hook-opcodes

Conversation

@crystarm

Copy link
Copy Markdown
Contributor

Fixes #25338.

phpdbg's opcode listing only iterated the class function table, so property hooks were omitted. Targeted hook selectors also did not work because the selector parser discarded the hook suffix and lowercased the case-sensitive property name.

This change:

  • includes declared property hooks in class opcode listings;
  • adds hooks to the method count and name list;
  • supports -p=Class::$property::get/set;
  • preserves property-name case while keeping function and method lookup
    case-insensitive;
  • avoids duplicate trait-cloned hook op arrays;
  • adds PHPT coverage.

@bwoebi

bwoebi commented Nov 10, 2026

Copy link
Copy Markdown
Member

This should probably be based on top of PHP 8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

phpdbg's opcode listing does not include the bodies of property hooks

2 participants