Repository navigation
fix: avoid orphan else in optional union JSON body transform - #1521
Open
EnesKartal wants to merge 1 commit into
Open
EnesKartal wants to merge 1 commit into
EnesKartal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1520.
Summary
union_property.py.jinja(transformmacro), initializens.contains_modified_propertiesasnot property.required and not skip_unsetso that whenskip_unset=Trueskips theif isinstance(..., Unset):branch (as inendpoint_macros.py.jinjajson_body), no orphanelse:is emitted when all union members lack atransformmacro.not property.required and skip_unsetis true, guard fallback and trailing branches withif not isinstance(..., Unset):/elif not isinstance(..., Unset):/elif isinstance(..., ...):instead of falling into an unconditional assignment orelse:.tests/test_templates/test_endpoint_macros.py.pytest tests,end_to_end_tests/test_end_to_end.py(all 5 snapshots passing),ruff check,ruff format --check, andmypy openapi_python_client.