Repository navigation
Conversation
On large updates, the raw diff is not really human parsable. It can sometimes exceed the maximum length for comments, resulting in no diff being shown. To make reviews easier / more likely to spot something wrong, it now outputs a table, and report failures in PR checks. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
aduh95
added
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On large updates, the raw diff is not really human parsable. It can sometimes exceed the maximum length for comments, resulting in no diff being shown.
To make reviews easier / more likely to spot something wrong, it now outputs a table, and report failures in PR checks.
I've run the script locally and posted the output in #67334 (comment)