Repository navigation
Fixes: #45381 - #50328
Closed
jayshreek3 wants to merge 1 commit into
Closed
Fixes: #45381#50328jayshreek3 wants to merge 1 commit into
jayshreek3 wants to merge 1 commit into
Conversation
Member
|
This is already documented in
I would add the links in the Web Streams documentation without duplicating the contents. |
Mifrill
reviewed
Nov 8, 2023
Comment on lines
+1749
to
+1751
| The `.fromWeb()` method converts a web stream to a Node.js stream. It takes a `ReadableStream` or `WritableStream` object as input and returns a Node.js `Readable` or `Writable` stream. | ||
|
|
||
| The following example shows how to convert a web `ReadableStream` object to a Node.js `Readable` stream: |
There was a problem hiding this comment.
Suggested change
| The `.fromWeb()` method converts a web stream to a Node.js stream. It takes a `ReadableStream` or `WritableStream` object as input and returns a Node.js `Readable` or `Writable` stream. | |
| The following example shows how to convert a web `ReadableStream` object to a Node.js `Readable` stream: | |
| The `.fromWeb()` method converts a web stream to a Node.js stream by taking a `ReadableStream` or `WritableStream` object as input and returning a Node.js `Readable` or `Writable` stream. | |
| The following example demonstrates how to convert a web `ReadableStream` object into a Node.js `Readable` stream: |
Member
|
Hi! @lpinca suggested that this PR includes duplicated code from another part of the Node.js ecosystem, and therefor, it's implementation may be redundant. If in agreement, please close this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.