Skip to content

Fixes: #45381 - #50328

Closed
jayshreek3 wants to merge 1 commit into
nodejs:mainfrom
jayshreek3:#45381
Closed

jayshreek3 wants to merge 1 commit into
nodejs:mainfrom
jayshreek3:#45381

Conversation

@jayshreek3

Copy link
Copy Markdown

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 22, 2023
@lpinca

lpinca commented Oct 22, 2023

Copy link
Copy Markdown
Member

Comment thread doc/api/webstreams.md
Comment on lines +1749 to +1751
The `.fromWeb()` method converts a web stream to a Node.js stream. It takes a `ReadableStream` or `WritableStream` object as input and returns a Node.js `Readable` or `Writable` stream.

The following example shows how to convert a web `ReadableStream` object to a Node.js `Readable` stream:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `.fromWeb()` method converts a web stream to a Node.js stream. It takes a `ReadableStream` or `WritableStream` object as input and returns a Node.js `Readable` or `Writable` stream.
The following example shows how to convert a web `ReadableStream` object to a Node.js `Readable` stream:
The `.fromWeb()` method converts a web stream to a Node.js stream by taking a `ReadableStream` or `WritableStream` object as input and returning a Node.js `Readable` or `Writable` stream.
The following example demonstrates how to convert a web `ReadableStream` object into a Node.js `Readable` stream:

@avivkeller

avivkeller commented Apr 22, 2024 •

Copy link
Copy Markdown
Member

Hi! @lpinca suggested that this PR includes duplicated code from another part of the Node.js ecosystem, and therefor, it's implementation may be redundant. If in agreement, please close this PR.

This is an attempt to resolve older PRs.

@jayshreek3 jayshreek3 closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants