Repository navigation
Add stopAllThreadsOnSuspend and steppingResumesAllThreads to launch.json schema - #1145
TEJA P C (PCTEJA) wants to merge 1 commit into
Conversation
…son schema Both options are honoured by debugpy (read in _set_debug_options for launch and attach sessions, each defaulting to true) but were missing from the debugpy launch/attach configuration schema, so VS Code flagged them as unknown properties in launch.json. Add both boolean options (default true) with documentation to the launch and attach schemas in package.json, and declare them on ICommonDebugArguments so they are typed for both request types. Fixes microsoft#1133
|
TEJA P C (@PCTEJA) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree |
Summary
Fixes #1133.
stopAllThreadsOnSuspendandsteppingResumesAllThreadsare honoured by debugpy but were missing from this extension's launch.json schema, so VS Code reported them as unknown properties.Support in debugpy: both options are read in
_set_debug_optionsin pydevd's JSON command handler for launch and attach sessions (steppingResumesAllThreadsviaargs.get("steppingResumesAllThreads", True);stopAllThreadsOnSuspendadded in microsoft/debugpy#2010), each defaulting totrue`. The extension's launch/attach resolvers pass configuration through to the debug adapter unfiltered, so declaring the options in the schema and types is sufficient for them to be documented and validated.Changes
package.json: addsteppingResumesAllThreadsandstopAllThreadsOnSuspend(boolean,default: true, with descriptions documenting the behaviour and defaults) to both thelaunchandattachconfigurationAttributesschemas.src/extension/types.ts: declare both options onICommonDebugArguments, which is shared by the launch and attach argument types.No other files need changes: comparable debugpy-consumed options follow the same schema-and-types pattern (for example `breakOnSystemExit), and resolver changes are not required for passthrough options.
Testing
package.jsonparses as valid JSON; both properties present in both schemas withdefault: true.npm run compile-tests(tsc) passes.eslintandprettier --checkpass onsrc/extension/types.ts.Note: the full VS Code test-host suite was not run locally (it requires downloading a VS Code build); CI will exercise it.
This change was prepared with AI assistance (Muse, validated with Codex); I have reviewed every changed line and take responsibility for it.