Repository navigation
Return freshly cached post-super flow results - #65471
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Jake Bailey (jakebailey) wants to merge 1 commit into
Conversation
The shared-flow slow path has already traversed the antecedents and recorded its answer. Return that result rather than immediately walking the same control-flow graph again. Exercise fully initialized and missing-super paths across shared branches, loops, and finally blocks.
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the post-super() flow-analysis fix.
No open issues 🎉
What changed in this PR
This PR fixes a missing return in the native TypeScript checker so post-super() flow analysis immediately returns a freshly computed and cached result.
Changes:
- Return
postSuperafter caching it. - Add regression coverage for branching constructors, repeated
thisaccesses, loops, andtry/finally. - Add baselines recording expected diagnostics, JavaScript output, types, and symbols.
| File | Description |
|---|---|
tsc/testdata/tests/cases/compiler/postSuperSharedFlow.ts |
Tests valid and missing-super() flow paths. |
tsc/testdata/baselines/reference/compiler/postSuperSharedFlow.types |
Records expected type information. |
tsc/testdata/baselines/reference/compiler/postSuperSharedFlow.symbols |
Records expected symbol information. |
tsc/testdata/baselines/reference/compiler/postSuperSharedFlow.js |
Records expected JavaScript output. |
tsc/testdata/baselines/reference/compiler/postSuperSharedFlow.errors.txt |
Records two expected accesses to this before super(). |
tsc/internal/checker/flow.go |
Returns the freshly cached post-super() flow result. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing a return.