Repository navigation
Fix ASI diagnostics for Unicode line separators (U+2028 and U+2029) - #65461
Open
amr sarhan (amr807) wants to merge 3 commits into
Open
amr sarhan (amr807) wants to merge 3 commits into
amr sarhan (amr807) wants to merge 3 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect and missing automatic semicolon insertion (ASI) diagnostics when source code contains the Unicode line separators U+2028 (LINE SEPARATOR) and U+2029 (PARAGRAPH SEPARATOR).
These characters are valid ECMAScript line terminators. However, parts of the Go implementation were checking source text one byte at a time. Since both characters occupy three bytes in UTF-8, these checks could incorrectly detect line breaks and calculate source positions.
Changes
StopAfterLineBreakbehavior and existing LF/CRLF behavior.Testing
go -C ./tsc test -count=1 ./...betterErrorForAccidentalCall.Related issue
Fixes #65433.
AI assistance disclosure
I used OpenAI ChatGPT (GPT-6) as an AI coding assistant during bug investigation, implementation, code review, and test development. I personally reviewed the changes, verified the implementation, ran the tests, and understand the submitted code. I will personally maintain this pull request and respond to review feedback.