Repository navigation
Conversation
The host/www redirect middlewares concatenated req.Host and req.RequestURI into Location without checking the host or sanitizing the URI. A Host of "www." plus a path such as /attacker.com/login produced https:///attacker.com/login, which browsers treat as an open redirect. The www. prefix match was also case-sensitive, and a forwarded ws/wss scheme could be copied into the Location. Validate the host after construction, strip www. case-insensitively, sanitize the URI the same way as the slash middleware, and map ws/wss back to http/https. Fixes labstack#3217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host and www redirect middlewares built
Locationby concatenatingreq.Hostandreq.RequestURI. AHostofwww.plus a path such as/attacker.com/loginproducedhttps:///attacker.com/login, which browsers normalize to an off-site URL (CWE-601). Thewww.prefix check was case-sensitive, absolute-form request URIs were not sanitized the wayAddTrailingSlashalready does, and a forwardedws/wssscheme could be copied into the redirect.The middleware now sanitizes the URI, strips
www.case-insensitively, mapsws/wssback tohttp/https, and rejects a redirect whose host is empty or contains authority delimiters.Fixes #3217