Skip to content

fix(abi): put the Eq doc comment above public export in Types.idr - #285

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/abi-types-eq-doc
Nov 10, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/abi-types-eq-doc

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

#277 merged at b332b5f. The fix for its one failing check (7070cb8) was pushed to the branch but did not land.

Problem

On main, src/abi/Types.idr has the ||| doc comment between public export and Eq Severity where. Idris2 0.7.0 rejects it:

Error: Keyword 'public' is not a valid start to a declaration.
PanicAttack.ABI.Types:23:1--23:7

So the required job "Idris2 ABI proofs type-check" fails on main and on every PR based on it (failing run).

Change

Move the doc line above public export. One line, no change to any declaration.

Verification

The same commit is on #277's branch. The other 4 modules passed in the failing run; this is the only error.


Generated by Claude Code

The merge placed '||| Equality on severity' between 'public export' and
'Eq Severity where'. Idris2 then rejects 'public export' as a declaration
start (idris-abi on b332b5f). Doc comment first, as on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZnmBahbhfkFEP6ark4
@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1aaf9113-9fba-43cf-a699-b9fab658ac11
Commits

Reviewing files that changed from the base of the PR and between 9986ca4 and c22f7b9.

Files selected for processing: 1

  • src/abi/Types.idr
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 10, 2026 16:50
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T16:50:10.712920Z
We couldn’t complete this review. Comment @codex review to try again.
c22f7b9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@hyperpolymath
hyperpolymath merged commit c7b1c44 into main Nov 10, 2026
73 checks passed
@hyperpolymath
hyperpolymath deleted the claude/abi-types-eq-doc branch November 10, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants