Repository navigation
deps + fft Exact/FMA options (supersedes #106) - #117
Merged
Merged
Conversation
…ench v0.3.0; bench tidied Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tale arm64 max comment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… arm64 comment names FMAX/FMIN Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updates of Renovate's #106, applied on current main with every module tidied:
goline moves to 1.27.3internal/kernels/asmgen: go-asmgen v0.23.0 → v0.23.2.go generaterewritessum_*.swith no change.bench: go-scikit/refbench v0.1.2 → v0.3.0, and its indirect requirements follow the root module.#106 failed in "perf (refbench CI mode)" with
go: updates to go.mod needed; go mod tidy.bench/reaches the root module throughreplace ../, so its indirect requirements have to follow every root bump, and Renovate's run does not re-tidy it after the root module changes.Also, after review:
fft.OptionsgainsExactandFMA. They are passed to go-fft v0.29.0's options of the same names. Exact is go-fft's reference arithmetic, today its default. FMA fuses the twiddles on amd64 with FMA3. Asking for both is refused withErrArgs.TestArithmeticOptionscovers this: Exact gives the default bits, FMA stays within 64·eps·max|X| of the default, both together are refused, and the repeated-axis path passes both through.fftstays at 100 % coverage.fft.Options{Exact: true}, since the README promised that option.internal/kernels/asmgen/arm64/gen.go: the comment still said a SIMD max was out of reach because of bit identity, but Max and Min have come from go-simd/floats' NEON kernels for a while.paritycheck repo(fleettools v0.106) refused that sentence; it passes again. The.sfiles are unchanged.Local runs:
go test ./...passes (root, fft, kernels, linalg, random), andgo vet ./...inbenchis clean.Supersedes Renovate's pull request: Refs #106 (Renovate closes it once main has these versions).
🤖 Generated with Claude Code